Commit 20d89547 authored by antma's avatar antma

replace sprintf call with snprintf for open image command

parent 35f981d5
...@@ -1764,14 +1764,17 @@ void end_load (struct download *D) { ...@@ -1764,14 +1764,17 @@ void end_load (struct download *D) {
if (D->next == 1) { if (D->next == 1) {
logprintf ("Done: %s\n", D->name); logprintf ("Done: %s\n", D->name);
} else if (D->next == 2) { } else if (D->next == 2) {
static char buf[1000]; static char buf[PATH_MAX];
sprintf (buf, OPEN_BIN, D->name); if (snprintf (buf, sizeof (buf), OPEN_BIN, D->name) >= (int) sizeof (buf)) {
logprintf ("Open image command buffer overflow\n");
} else {
int x = system (buf); int x = system (buf);
if (x < 0) { if (x < 0) {
logprintf ("Can not open image viewer: %m\n"); logprintf ("Can not open image viewer: %m\n");
logprintf ("Image is at %s\n", D->name); logprintf ("Image is at %s\n", D->name);
} }
} }
}
if (D->iv) { if (D->iv) {
free (D->iv); free (D->iv);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment