Skip to content

P
pve-manager
Commit aeacfe40 authored by Dietmar Maurer's avatar Dietmar Maurer
Browse files
Options

use backgroud tasks for service actions

parent 72a74d5d
Show whitespace changes
Inline Side-by-side
Showing with 198 additions and 35 deletions
PVE/API2/OpenVZ.pm
View file @ aeacfe40
......@@ -705,13 +705,9 @@ __PACKAGE__->register_method({
my $cmd = ['vzctl', 'start', $vmid];
PVE::Tools::run_command($cmd);
return;
};
my $upid = $rpcenv->fork_worker('vzstart', $vmid, $user, $realcmd);
return $upid;
return $rpcenv->fork_worker('vzstart', $vmid, $user, $realcmd);
}});
__PACKAGE__->register_method({
......
PVE/API2/Services.pm
View file @ aeacfe40
......@@ -25,9 +25,16 @@ my $service_list = {
cron => { name => 'CRON', desc => 'Daemon to execute scheduled commands' },
pvedaemon => { name => 'NodeManager', desc => 'PVE node manager daemon' },
corosync => { name => 'CMan', desc => 'CMan/Corosync cluster daemon' },
clvm => { name => 'CLVM', desc => 'LVM cluster locking daemon' },
pvecluster => { name => 'PVECluster', desc => 'Proxmox VE cluster file system' },
};
my $service_prop_desc = {
description => "Service ID",
type => 'string',
enum => [ keys %{$service_list} ],
};
my $service_cmd = sub {
my ($service, $cmd) = @_;
......@@ -36,8 +43,6 @@ my $service_cmd = sub {
die "unknown service command '$cmd'\n"
if $cmd !~ m/^(start|stop|restart|reload)$/;
$cmd = $1; # untaint
if ($service eq 'postfix') {
$initd_cmd = '/etc/init.d/postfix';
} elsif ($service eq 'pvecluster') {
......@@ -54,6 +59,7 @@ my $service_cmd = sub {
}
} elsif ($service eq 'apache') {
if ($cmd eq 'restart') {
print "graceful apache restart\n";
$initd_cmd = '/usr/sbin/apache2ctl';
$cmd = 'graceful';
} else {
......@@ -80,7 +86,10 @@ my $service_cmd = sub {
} elsif ($service eq 'cron') {
$initd_cmd = '/etc/init.d/cron';
} elsif ($service eq 'corosync') {
$cmd = 'start' if $cmd eq 'restart';
$initd_cmd = '/etc/init.d/cman';
} elsif ($service eq 'clvm') {
$initd_cmd = '/etc/init.d/clvm';
} elsif ($service eq 'sshd') {
$initd_cmd = '/etc/init.d/ssh';
} else {
......@@ -111,6 +120,8 @@ my $service_state = sub {
$pid_file = '/var/run/crond.pid';
} elsif ($service eq 'corosync') {
$pid_file = '/var/run/corosync.pid';
} elsif ($service eq 'clvm') {
$pid_file = '/var/run/clvmd.pid';
} elsif ($service eq 'syslog') {
$pid_file = '/var/run/rsyslogd.pid';
} else {
......@@ -174,10 +185,46 @@ __PACKAGE__->register_method ({
return $res;
}});
__PACKAGE__->register_method ({
name => 'state',
__PACKAGE__->register_method({
name => 'srvcmdidx',
path => '{service}',
method => 'GET',
description => "Directory index",
parameters => {
additionalProperties => 0,
properties => {
node => get_standard_option('pve-node'),
service => $service_prop_desc,
},
},
returns => {
type => 'array',
items => {
type => "object",
properties => {
subdir => { type => 'string' },
},
},
links => [ { rel => 'child', href => "{subdir}" } ],
},
code => sub {
my ($param) = @_;
my $res = [
{ subdir => 'state' },
{ subdir => 'start' },
{ subdir => 'stop' },
{ subdir => 'restart' },
{ subdir => 'reload' },
];
return $res;
}});
__PACKAGE__->register_method ({
name => 'service_state',
path => '{service}/state',
method => 'GET',
permissions => {
path => '/nodes/{node}',
privs => [ 'Sys.Audit' ],
......@@ -189,11 +236,7 @@ __PACKAGE__->register_method ({
additionalProperties => 0,
properties => {
node => get_standard_option('pve-node'),
service => {
description => "Service ID",
type => 'string',
enum => [ keys %{$service_list} ],
},
service => $service_prop_desc,
},
},
returns => {
......@@ -213,34 +256,153 @@ __PACKAGE__->register_method ({
}});
__PACKAGE__->register_method ({
name => 'cmd',
path => '{service}',
method => 'PUT',
description => "Execute service commands.",
name => 'service_start',
path => '{service}/start',
method => 'POST',
description => "Start service.",
proxyto => 'node',
protected => 1,
parameters => {
additionalProperties => 0,
properties => {
node => get_standard_option('pve-node'),
service => {
description => "Service ID",
service => $service_prop_desc,
},
},
returns => {
type => 'string',
enum => [ keys %{$service_list} ],
},
command => {
description => "The command to execute. The only valid command for service 'apache' and 'pvedaemon' is 'restart', because both services are required by this API.",
code => sub {
my ($param) = @_;
my $rpcenv = PVE::RPCEnvironment::get();
my $user = $rpcenv->get_user();
my $si = $service_list->{$param->{service}};
my $realcmd = sub {
my $upid = shift;
syslog('info', "starting service $param->{service}: $upid\n");
&$service_cmd($param->{service}, 'start');
};
return $rpcenv->fork_worker('srvstart', $param->{service}, $user, $realcmd);
}});
__PACKAGE__->register_method ({
name => 'service_stop',
path => '{service}/stop',
method => 'POST',
description => "Stop service.",
proxyto => 'node',
protected => 1,
parameters => {
additionalProperties => 0,
properties => {
node => get_standard_option('pve-node'),
service => $service_prop_desc,
},
},
returns => {
type => 'string',
},
code => sub {
my ($param) = @_;
my $rpcenv = PVE::RPCEnvironment::get();
my $user = $rpcenv->get_user();
my $si = $service_list->{$param->{service}};
my $realcmd = sub {
my $upid = shift;
syslog('info', "stoping service $param->{service}: $upid\n");
&$service_cmd($param->{service}, 'stop');
};
return $rpcenv->fork_worker('srvstop', $param->{service}, $user, $realcmd);
}});
__PACKAGE__->register_method ({
name => 'service_restart',
path => '{service}/restart',
method => 'POST',
description => "Restart service.",
proxyto => 'node',
protected => 1,
parameters => {
additionalProperties => 0,
properties => {
node => get_standard_option('pve-node'),
service => $service_prop_desc,
},
},
returns => {
type => 'string',
enum => [qw(start stop restart reload)],
},
code => sub {
my ($param) = @_;
my $rpcenv = PVE::RPCEnvironment::get();
my $user = $rpcenv->get_user();
my $si = $service_list->{$param->{service}};
my $realcmd = sub {
my $upid = shift;
syslog('info', "re-starting service $param->{service}: $upid\n");
&$service_cmd($param->{service}, 'restart');
};
return $rpcenv->fork_worker('srvrestart', $param->{service}, $user, $realcmd);
}});
__PACKAGE__->register_method ({
name => 'service_reload',
path => '{service}/reload',
method => 'POST',
description => "Reload service.",
proxyto => 'node',
protected => 1,
parameters => {
additionalProperties => 0,
properties => {
node => get_standard_option('pve-node'),
service => $service_prop_desc,
},
},
returns => {
type => 'string',
},
returns => { type => 'null'},
code => sub {
my ($param) = @_;
my $rpcenv = PVE::RPCEnvironment::get();
my $user = $rpcenv->get_user();
my $si = $service_list->{$param->{service}};
&$service_cmd($param->{service}, $param->{command});
return undef;
my $realcmd = sub {
my $upid = shift;
syslog('info', "reloading service $param->{service}: $upid\n");
&$service_cmd($param->{service}, 'reload');
};
return $rpcenv->fork_worker('srvreload', $param->{service}, $user, $realcmd);
}});
www/manager/node/ServiceView.js
View file @ aeacfe40
......@@ -27,15 +27,20 @@ Ext.define('PVE.node.ServiceView', {
var sm = me.getSelectionModel();
var rec = sm.getSelection()[0];
PVE.Utils.API2Request({
url: "/nodes/" + nodename + "/services/" + rec.data.service,
params: { command: cmd },
method: 'PUT',
url: "/nodes/" + nodename + "/services/" + rec.data.service + "/" + cmd,
method: 'POST',
failure: function(response, opts) {
Ext.Msg.alert('Error', response.htmlStatus);
me.loading = true;
},
success: function(response, opts) {
rstore.startUpdate();
var upid = response.result.data;
var win = Ext.create('PVE.window.TaskViewer', {
upid: upid
});
win.show();
}
});
};
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

Technounit-GROUP 2023