Commit c26bc841 authored by Joshua Tauberer's avatar Joshua Tauberer

more for dnspython exception with IPv6 addresses

fixes #945, corrects prev commit (#947) in case of multiple AAAA records, adds changelog
parent 163daea4
...@@ -8,6 +8,10 @@ ownCloud: ...@@ -8,6 +8,10 @@ ownCloud:
* Updated to ownCloud to 8.2.7. * Updated to ownCloud to 8.2.7.
Control Panel:
* Fixed a crash that occurs when there are IPv6 DNS records due to a bug in dnspython 1.14.0.
v0.19b (August 20, 2016) v0.19b (August 20, 2016)
------------------------ ------------------------
......
...@@ -245,12 +245,15 @@ def get_certificates_to_provision(env, show_extended_problems=True, force_domain ...@@ -245,12 +245,15 @@ def get_certificates_to_provision(env, show_extended_problems=True, force_domain
# https://github.com/rthalley/dnspython/issues/204 # https://github.com/rthalley/dnspython/issues/204
# #
# BEGIN HOTFIX # BEGIN HOTFIX
if isinstance(response[0].to_text(), bytes): def rdata__str__(r):
response = [response[0].to_text().decode('utf-8')] s = r.to_text()
if isinstance(s, bytes):
s = s.decode('utf-8')
return s
# END HOTFIX # END HOTFIX
if len(response) != 1 or str(response[0]) != value: if len(response) != 1 or rdata__str__(response[0]) != value:
problems[domain] = "Domain control validation cannot be performed for this domain because DNS points the domain to another machine (%s %s)." % (rtype, ", ".join(str(r) for r in response)) problems[domain] = "Domain control validation cannot be performed for this domain because DNS points the domain to another machine (%s %s)." % (rtype, ", ".join(rdata__str__(r) for r in response))
return False return False
return True return True
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment