TO attribute of JIDs is now validated when clients are directly connected.

git-svn-id: http://svn.igniterealtime.org/svn/repos/wildfire/trunk@6936 b35dd754-fafc-0310-a699-88a17e54d16e

src/java/org/jivesoftware/wildfire/net/ClientStanzaHandler.java

@@ -59,6 +59,10 @@ public class ClientStanzaHandler extends StanzaHandler {
         return JiveGlobals.getBooleanProperty("xmpp.client.validate.host",false);
     }
 
+    boolean validateJIDs() {
+        return true;
+    }
+
     boolean createSession(String namespace, String serverName, XmlPullParser xpp, Connection connection)
             throws XmlPullParserException {
         if ("jabber:client".equals(namespace)) {

src/java/org/jivesoftware/wildfire/net/MultiplexerStanzaHandler.java

@@ -117,6 +117,10 @@ public class MultiplexerStanzaHandler extends StanzaHandler {
         return false;
     }
 
+    boolean validateJIDs() {
+        return false;
+    }
+
     boolean createSession(String namespace, String serverName, XmlPullParser xpp, Connection connection)
             throws XmlPullParserException {
         if (getNamespace().equals(namespace)) {

src/java/org/jivesoftware/wildfire/net/StanzaHandler.java

@@ -164,7 +164,7 @@ public abstract class StanzaHandler {
         if ("message".equals(tag)) {
             Message packet;
             try {
-                packet = new Message(doc, true);
+                packet = new Message(doc, !validateJIDs());
             }
             catch(IllegalArgumentException e) {
                 Log.debug("Rejecting packet. JID malformed", e);
@@ -182,7 +182,7 @@ public abstract class StanzaHandler {
         else if ("presence".equals(tag)) {
             Presence packet;
             try {
-                packet = new Presence(doc, true);
+                packet = new Presence(doc, !validateJIDs());
             }
             catch (IllegalArgumentException e) {
                 Log.debug("Rejecting packet. JID malformed", e);
@@ -263,7 +263,7 @@ public abstract class StanzaHandler {
             return new Roster(doc);
         }
         else {
-            return new IQ(doc, true);
+            return new IQ(doc, !validateJIDs());
         }
     }
 
@@ -619,6 +619,16 @@ public abstract class StanzaHandler {
      */
     abstract boolean validateHost();
 
+    /**
+     * Returns true if the value of the 'to' attribute of {@link IQ}, {@link Presence} and
+     * {@link Message} must be validated. Connection Managers perform their own
+     * JID validation so there is no need to validate JIDs again but when clients are
+     * directly connected to the server then we need to validate JIDs.
+     *
+     * @return rue if the value of the 'to' attribute of IQ, Presence and Messagemust be validated.
+     */
+    abstract boolean validateJIDs();
+
     /**
      * Creates the appropriate {@link Session} subclass based on the specified namespace.
      *