Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
O
Openfire
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Administrator
Openfire
Commits
1cd3c3ba
Commit
1cd3c3ba
authored
Dec 17, 2014
by
Christian Schudt
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Disable SSLv3 for socket connections to avoid POODLE vulnerability.
parent
3a9f3c42
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
1 deletion
+8
-1
ConnectionHandler.java
...java/org/jivesoftware/openfire/nio/ConnectionHandler.java
+6
-1
NIOConnection.java
src/java/org/jivesoftware/openfire/nio/NIOConnection.java
+2
-0
No files found.
src/java/org/jivesoftware/openfire/nio/ConnectionHandler.java
View file @
1cd3c3ba
...
@@ -38,6 +38,8 @@ import org.xmlpull.v1.XmlPullParserException;
...
@@ -38,6 +38,8 @@ import org.xmlpull.v1.XmlPullParserException;
import
org.xmlpull.v1.XmlPullParserFactory
;
import
org.xmlpull.v1.XmlPullParserFactory
;
import
org.xmpp.packet.StreamError
;
import
org.xmpp.packet.StreamError
;
import
javax.net.ssl.SSLHandshakeException
;
/**
/**
* A ConnectionHandler is responsible for creating new sessions, destroying sessions and delivering
* A ConnectionHandler is responsible for creating new sessions, destroying sessions and delivering
* received XML stanzas to the proper StanzaHandler.
* received XML stanzas to the proper StanzaHandler.
...
@@ -146,6 +148,9 @@ public abstract class ConnectionHandler extends IoHandlerAdapter {
...
@@ -146,6 +148,9 @@ public abstract class ConnectionHandler extends IoHandlerAdapter {
if
(
cause
instanceof
IOException
)
{
if
(
cause
instanceof
IOException
)
{
// TODO Verify if there were packets pending to be sent and decide what to do with them
// TODO Verify if there were packets pending to be sent and decide what to do with them
Log
.
info
(
"ConnectionHandler reports IOException for session: "
+
session
,
cause
);
Log
.
info
(
"ConnectionHandler reports IOException for session: "
+
session
,
cause
);
if
(
cause
instanceof
SSLHandshakeException
)
{
session
.
close
(
true
);
}
}
}
else
if
(
cause
instanceof
ProtocolDecoderException
)
{
else
if
(
cause
instanceof
ProtocolDecoderException
)
{
Log
.
warn
(
"Closing session due to exception: "
+
session
,
cause
);
Log
.
warn
(
"Closing session due to exception: "
+
session
,
cause
);
...
...
src/java/org/jivesoftware/openfire/nio/NIOConnection.java
View file @
1cd3c3ba
...
@@ -367,6 +367,8 @@ public class NIOConnection implements Connection {
...
@@ -367,6 +367,8 @@ public class NIOConnection implements Connection {
SslFilter
filter
=
new
SslFilter
(
tlsContext
);
SslFilter
filter
=
new
SslFilter
(
tlsContext
);
filter
.
setUseClientMode
(
clientMode
);
filter
.
setUseClientMode
(
clientMode
);
// Disable SSLv3 due to POODLE vulnerability.
filter
.
setEnabledProtocols
(
new
String
[]{
"TLSv1"
,
"TLSv1.1"
,
"TLSv1.2"
});
if
(
authentication
==
ClientAuth
.
needed
)
{
if
(
authentication
==
ClientAuth
.
needed
)
{
filter
.
setNeedClientAuth
(
true
);
filter
.
setNeedClientAuth
(
true
);
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment