Fix the show more social account icon not showing,

Plus fix file indentation.

app/src/main/java/chat/rocket/android/authentication/login/ui/LoginFragment.kt

@@ -2,7 +2,6 @@ package chat.rocket.android.authentication.login.ui
 
 import DrawableHelper
 import android.app.Activity
-import android.app.AlertDialog
 import android.content.Intent
 import android.os.Build
 import android.os.Bundle
@@ -14,8 +13,8 @@ import android.view.ViewGroup
 import android.view.ViewTreeObserver
 import android.widget.ImageButton
 import android.widget.ScrollView
+import androidx.core.view.isVisible
 import androidx.core.view.postDelayed
-import chat.rocket.android.BuildConfig
 import chat.rocket.android.R
 import chat.rocket.android.authentication.domain.model.LoginDeepLinkInfo
 import chat.rocket.android.authentication.login.presentation.LoginPresenter
@@ -37,7 +36,8 @@ internal const val REQUEST_CODE_FOR_CAS = 1
 internal const val REQUEST_CODE_FOR_OAUTH = 2
 
 class LoginFragment : Fragment(), LoginView {
-    @Inject lateinit var presenter: LoginPresenter
+    @Inject
+    lateinit var presenter: LoginPresenter
     private var isOauthViewEnable = false
     private val layoutListener = ViewTreeObserver.OnGlobalLayoutListener {
         areLoginOptionsNeeded()
@@ -61,7 +61,11 @@ class LoginFragment : Fragment(), LoginView {
         deepLinkInfo = arguments?.getParcelable(DEEP_LINK_INFO)
     }
 
-    override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? =
+    override fun onCreateView(
+        inflater: LayoutInflater,
+        container: ViewGroup?,
+        savedInstanceState: Bundle?
+    ): View? =
         container?.inflate(R.layout.fragment_authentication_log_in)
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
@@ -94,7 +98,10 @@ class LoginFragment : Fragment(), LoginView {
                 }
             } else if (requestCode == REQUEST_CODE_FOR_OAUTH) {
                 data?.apply {
-                    presenter.authenticateWithOauth(getStringExtra(INTENT_OAUTH_CREDENTIAL_TOKEN), getStringExtra(INTENT_OAUTH_CREDENTIAL_SECRET))
+                    presenter.authenticateWithOauth(
+                        getStringExtra(INTENT_OAUTH_CREDENTIAL_TOKEN),
+                        getStringExtra(INTENT_OAUTH_CREDENTIAL_SECRET)
+                    )
                 }
             }
         }
@@ -102,25 +109,29 @@ class LoginFragment : Fragment(), LoginView {
 
     private fun tintEditTextDrawableStart() {
         ui {
-            val personDrawable = DrawableHelper.getDrawableFromId(R.drawable.ic_assignment_ind_black_24dp, it)
+            val personDrawable =
+                DrawableHelper.getDrawableFromId(R.drawable.ic_assignment_ind_black_24dp, it)
             val lockDrawable = DrawableHelper.getDrawableFromId(R.drawable.ic_lock_black_24dp, it)
 
             val drawables = arrayOf(personDrawable, lockDrawable)
             DrawableHelper.wrapDrawables(drawables)
             DrawableHelper.tintDrawables(drawables, it, R.color.colorDrawableTintGrey)
-            DrawableHelper.compoundDrawables(arrayOf(text_username_or_email, text_password), drawables)
+            DrawableHelper.compoundDrawables(
+                arrayOf(text_username_or_email, text_password),
+                drawables
+            )
         }
     }
 
     override fun showLoading() {
         ui {
-            view_loading.setVisible(true)
+            view_loading.isVisible = true
         }
     }
 
     override fun hideLoading() {
         ui {
-            view_loading.setVisible(false)
+            view_loading.isVisible = false
         }
     }
 
@@ -142,23 +153,25 @@ class LoginFragment : Fragment(), LoginView {
 
     override fun showFormView() {
         ui {
-            text_username_or_email.setVisible(true)
-            text_password.setVisible(true)
+            text_username_or_email.isVisible = true
+            text_password.isVisible = true
         }
     }
 
     override fun hideFormView() {
         ui {
-            text_username_or_email.setVisible(false)
-            text_password.setVisible(false)
+            text_username_or_email.isVisible = false
+            text_password.isVisible = false
         }
     }
 
     override fun setupLoginButtonListener() {
         ui {
             button_log_in.setOnClickListener {
-                presenter.authenticateWithUserAndPassword(text_username_or_email.textContent,
-                        text_password.textContent)
+                presenter.authenticateWithUserAndPassword(
+                    text_username_or_email.textContent,
+                    text_password.textContent
+                )
             }
         }
     }
@@ -181,21 +194,23 @@ class LoginFragment : Fragment(), LoginView {
 
     override fun showCasButton() {
         ui {
-            button_cas.setVisible(true)
+            button_cas.isVisible = true
         }
     }
 
     override fun hideCasButton() {
         ui {
-            button_cas.setVisible(false)
+            button_cas.isVisible = false
         }
     }
 
     override fun setupCasButtonListener(casUrl: String, casToken: String) {
         ui { activity ->
             button_cas.setOnClickListener {
-                startActivityForResult(activity.casWebViewIntent(casUrl, casToken),
-                        REQUEST_CODE_FOR_CAS)
+                startActivityForResult(
+                    activity.casWebViewIntent(casUrl, casToken),
+                    REQUEST_CODE_FOR_CAS
+                )
                 activity.overridePendingTransition(R.anim.slide_up, R.anim.hold)
             }
         }
@@ -203,7 +218,7 @@ class LoginFragment : Fragment(), LoginView {
 
     override fun showSignUpView() {
         ui {
-            text_new_to_rocket_chat.setVisible(true)
+            text_new_to_rocket_chat.isVisible = true
         }
     }
 
@@ -224,7 +239,7 @@ class LoginFragment : Fragment(), LoginView {
 
     override fun hideSignUpView() {
         ui {
-            text_new_to_rocket_chat.setVisible(false)
+            text_new_to_rocket_chat.isVisible = false
         }
     }
 
@@ -232,26 +247,26 @@ class LoginFragment : Fragment(), LoginView {
         ui {
             isOauthViewEnable = true
             showThreeSocialAccountsMethods()
-            social_accounts_container.setVisible(true)
+            social_accounts_container.isVisible = true
         }
     }
 
     override fun disableOauthView() {
         ui {
             isOauthViewEnable = false
-            social_accounts_container.setVisible(false)
+            social_accounts_container.isVisible = false
         }
     }
 
     override fun showLoginButton() {
         ui {
-            button_log_in.setVisible(true)
+            button_log_in.isVisible = true
         }
     }
 
     override fun hideLoginButton() {
         ui {
-            button_log_in.setVisible(false)
+            button_log_in.isVisible = false
         }
     }
 
@@ -264,7 +279,10 @@ class LoginFragment : Fragment(), LoginView {
     override fun setupFacebookButtonListener(facebookOauthUrl: String, state: String) {
         ui { activity ->
             button_facebook.setOnClickListener {
-                startActivityForResult(activity.oauthWebViewIntent(facebookOauthUrl, state), REQUEST_CODE_FOR_OAUTH)
+                startActivityForResult(
+                    activity.oauthWebViewIntent(facebookOauthUrl, state),
+                    REQUEST_CODE_FOR_OAUTH
+                )
                 activity.overridePendingTransition(R.anim.slide_up, R.anim.hold)
             }
         }
@@ -279,7 +297,10 @@ class LoginFragment : Fragment(), LoginView {
     override fun setupGithubButtonListener(githubUrl: String, state: String) {
         ui { activity ->
             button_github.setOnClickListener {
-                startActivityForResult(activity.oauthWebViewIntent(githubUrl, state), REQUEST_CODE_FOR_OAUTH)
+                startActivityForResult(
+                    activity.oauthWebViewIntent(githubUrl, state),
+                    REQUEST_CODE_FOR_OAUTH
+                )
                 activity.overridePendingTransition(R.anim.slide_up, R.anim.hold)
             }
         }
@@ -291,11 +312,15 @@ class LoginFragment : Fragment(), LoginView {
         }
     }
 
-    // TODO: Use custom tabs instead of web view. See https://github.com/RocketChat/Rocket.Chat.Android/issues/968
+    // TODO: Use custom tabs instead of web view.
+    // See https://github.com/RocketChat/Rocket.Chat.Android/issues/968
     override fun setupGoogleButtonListener(googleUrl: String, state: String) {
         ui { activity ->
             button_google.setOnClickListener {
-                startActivityForResult(activity.oauthWebViewIntent(googleUrl, state), REQUEST_CODE_FOR_OAUTH)
+                startActivityForResult(
+                    activity.oauthWebViewIntent(googleUrl, state),
+                    REQUEST_CODE_FOR_OAUTH
+                )
                 activity.overridePendingTransition(R.anim.slide_up, R.anim.hold)
             }
         }
@@ -310,7 +335,10 @@ class LoginFragment : Fragment(), LoginView {
     override fun setupLinkedinButtonListener(linkedinUrl: String, state: String) {
         ui { activity ->
             button_linkedin.setOnClickListener {
-                startActivityForResult(activity.oauthWebViewIntent(linkedinUrl, state), REQUEST_CODE_FOR_OAUTH)
+                startActivityForResult(
+                    activity.oauthWebViewIntent(linkedinUrl, state),
+                    REQUEST_CODE_FOR_OAUTH
+                )
                 activity.overridePendingTransition(R.anim.slide_up, R.anim.hold)
             }
         }
@@ -337,7 +365,10 @@ class LoginFragment : Fragment(), LoginView {
     override fun setupGitlabButtonListener(gitlabUrl: String, state: String) {
         ui { activity ->
             button_gitlab.setOnClickListener {
-                startActivityForResult(activity.oauthWebViewIntent(gitlabUrl, state), REQUEST_CODE_FOR_OAUTH)
+                startActivityForResult(
+                    activity.oauthWebViewIntent(gitlabUrl, state),
+                    REQUEST_CODE_FOR_OAUTH
+                )
                 activity.overridePendingTransition(R.anim.slide_up, R.anim.hold)
             }
         }
@@ -345,7 +376,7 @@ class LoginFragment : Fragment(), LoginView {
 
     override fun setupFabListener() {
         ui {
-            button_fab.setVisible(true)
+            button_fab.isVisible = true
             button_fab.setOnClickListener({
                 button_fab.hide()
                 showRemainingSocialAccountsView()
@@ -355,8 +386,9 @@ class LoginFragment : Fragment(), LoginView {
     }
 
     override fun setupGlobalListener() {
-        // We need to setup the layout to hide and show the oauth interface when the soft keyboard is shown
-        // (means that the user touched the text_username_or_email or text_password EditText to fill that respective fields).
+        // We need to setup the layout to hide and show the oauth interface when the soft keyboard
+        // is shown (which means that the user has touched the text_username_or_email or
+        // text_password EditText to fill that respective fields).
         if (!isGlobalLayoutListenerSetUp) {
             scroll_view.viewTreeObserver.addOnGlobalLayoutListener(layoutListener)
             isGlobalLayoutListenerSetUp = true
@@ -385,7 +417,7 @@ class LoginFragment : Fragment(), LoginView {
                 (0..social_accounts_container.childCount)
                     .mapNotNull { social_accounts_container.getChildAt(it) as? ImageButton }
                     .filter { it.isClickable }
-                        .forEach { it.setVisible(true) }
+                    .forEach { it.isVisible = true }
             }
         }
     }
@@ -422,19 +454,20 @@ class LoginFragment : Fragment(), LoginView {
             .mapNotNull { social_accounts_container.getChildAt(it) as? ImageButton }
             .filter { it.isClickable }
             .take(3)
-            .forEach { it.setVisible(true) }
+            .forEach { it.isVisible = true }
     }
 
     private fun showOauthView() {
         if (isOauthViewEnable) {
-            social_accounts_container.setVisible(true)
+            social_accounts_container.isVisible = true
+            button_fab.isVisible = true
         }
     }
 
     private fun hideOauthView() {
         if (isOauthViewEnable) {
-            social_accounts_container.setVisible(false)
-            button_fab.setVisible(false)
+            social_accounts_container.isVisible = false
+            button_fab.isVisible = false
         }
     }
 }
\ No newline at end of file

app/src/main/java/chat/rocket/android/util/extensions/Ui.kt

@@ -15,6 +15,7 @@ import android.view.inputmethod.InputMethodManager
 import android.widget.Toast
 import chat.rocket.android.R
 
+// TODO: Remove. Use KTX instead.
 fun View.setVisible(visible: Boolean) {
     visibility = if (visible) {
         View.VISIBLE