Merge branch 'develop' into feature/multi-server

app/build.gradle

@@ -45,7 +45,7 @@ android {
         applicationId "chat.rocket.android"
         minSdkVersion 16
         targetSdkVersion rootProject.ext.targetSdkVersion
-        versionCode 35
+        versionCode 36
         versionName "1.0.18"
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true

app/src/main/java/chat/rocket/android/activity/MainActivity.java

@@ -43,6 +43,7 @@ import hugo.weaving.DebugLog;
 public class MainActivity extends AbstractAuthedActivity implements MainContract.View {
   private RoomToolbar toolbar;
   private StatusTicker statusTicker;
+  private SlidingPaneLayout pane;
   private MainContract.Presenter presenter;
 
   @Override
@@ -56,6 +57,8 @@ public class MainActivity extends AbstractAuthedActivity implements MainContract
     setContentView(R.layout.activity_main);
     toolbar = (RoomToolbar) findViewById(R.id.activity_main_toolbar);
     statusTicker = new StatusTicker();
+    pane = (SlidingPaneLayout) findViewById(R.id.sliding_pane);
+    setupToolbar();
   }
 
   @Override
@@ -82,9 +85,34 @@ public class MainActivity extends AbstractAuthedActivity implements MainContract
     startActivity(intent);
   }
 
+  private void setupToolbar() {
+    pane.setPanelSlideListener(new SlidingPaneLayout.PanelSlideListener() {
+      @Override
+      public void onPanelSlide(View view, float v) {
+        //Ref: ActionBarDrawerToggle#setProgress
+        toolbar.setNavigationIconProgress(v);
+      }
+
+      @Override
+      public void onPanelOpened(View view) {
+        toolbar.setNavigationIconVerticalMirror(true);
+      }
+
+      @Override
+      public void onPanelClosed(View view) {
+        toolbar.setNavigationIconVerticalMirror(false);
+      }
+    });
+
+    toolbar.setNavigationOnClickListener(view -> {
+      if (pane.isSlideable() && !pane.isOpen()) {
+        pane.openPane();
+      }
+    });
+  }
+
   private boolean closeSidebarIfNeeded() {
     // REMARK: Tablet UI doesn't have SlidingPane!
-    SlidingPaneLayout pane = (SlidingPaneLayout) findViewById(R.id.sliding_pane);
     if (pane != null && pane.isSlideable() && pane.isOpen()) {
       pane.closePane();
       return true;

app/src/main/java/chat/rocket/android/fragment/sidebar/SidebarMainFragment.java

@@ -43,16 +43,18 @@ import com.jakewharton.rxbinding2.support.v7.widget.RxSearchView;
 import com.jakewharton.rxbinding2.widget.RxCompoundButton;
 
 import io.reactivex.android.schedulers.AndroidSchedulers;
+import io.reactivex.disposables.Disposable;
+
 import java.util.ArrayList;
 import java.util.List;
 
 public class SidebarMainFragment extends AbstractFragment implements SidebarMainContract.View {
   private SidebarMainContract.Presenter presenter;
   private RoomListAdapter adapter;
-  private RecyclerView recyclerView;
   private SearchView searchView;
   private TextView loadMoreResultsText;
   private List<RoomSidebar> roomSidebarList;
+  private Disposable spotlightDisposable;
   private String hostname;
   private static final String HOSTNAME = "hostname";
 
@@ -139,7 +141,7 @@ public class SidebarMainFragment extends AbstractFragment implements SidebarMain
       }
     });
 
-    recyclerView = rootView.findViewById(R.id.room_list_container);
+    RecyclerView recyclerView = rootView.findViewById(R.id.room_list_container);
     recyclerView.setLayoutManager(new LinearLayoutManager(getContext(), LinearLayoutManager.VERTICAL, false));
     recyclerView.setAdapter(adapter);
 
@@ -148,13 +150,15 @@ public class SidebarMainFragment extends AbstractFragment implements SidebarMain
     RxSearchView.queryTextChanges(searchView)
             .observeOn(AndroidSchedulers.mainThread())
             .subscribe(charSequence -> {
-                adapter.setMode(RoomListAdapter.MODE_ROOM);
+                if (spotlightDisposable != null && !spotlightDisposable.isDisposed()) {
+                    spotlightDisposable.dispose();
+                }
+                presenter.disposeSubscriptions();
                 if (charSequence.length() == 0) {
                     loadMoreResultsText.setVisibility(View.GONE);
+                    adapter.setMode(RoomListAdapter.MODE_ROOM);
                     presenter.bindView(this);
-                    recyclerView.setVisibility(View.VISIBLE);
                 } else {
-                presenter.disposeSubscriptions();
                   filterRoomSidebarList(charSequence);
                 }
             });
@@ -179,16 +183,16 @@ public class SidebarMainFragment extends AbstractFragment implements SidebarMain
       }
 
       if (filteredRoomSidebarList.isEmpty()) {
-          recyclerView.setVisibility(View.GONE);
+          loadMoreResults();
       } else {
-          recyclerView.setVisibility(View.VISIBLE);
+          loadMoreResultsText.setVisibility(View.VISIBLE);
+          adapter.setMode(RoomListAdapter.MODE_ROOM);
           adapter.setRoomSidebarList(filteredRoomSidebarList);
       }
-      loadMoreResultsText.setVisibility(View.VISIBLE);
   }
 
   private void loadMoreResults() {
-    presenter.searchSpotlight(searchView.getQuery().toString())
+    spotlightDisposable = presenter.searchSpotlight(searchView.getQuery().toString())
             .toObservable()
             .observeOn(AndroidSchedulers.mainThread())
             .subscribe(this::showSearchSuggestions);
@@ -198,7 +202,6 @@ public class SidebarMainFragment extends AbstractFragment implements SidebarMain
     loadMoreResultsText.setVisibility(View.GONE);
     adapter.setMode(RoomListAdapter.MODE_SPOTLIGHT);
     adapter.setSpotlightList(spotlightList);
-    recyclerView.setVisibility(View.VISIBLE);
   }
 
   @SuppressLint("RxLeakedSubscription")