Unverified Commit 51012fd5 authored by Rafael Kellermann Streit's avatar Rafael Kellermann Streit Committed by GitHub

Merge pull request #1171 from MariusVolkhart/unitTests

[TESTS] Restore unit tests
parents 362bb948 24860c1a
...@@ -57,7 +57,7 @@ jobs: ...@@ -57,7 +57,7 @@ jobs:
command: ./gradlew lint command: ./gradlew lint
- run: - run:
name: Run Unit test name: Run Unit test
command: echo ./gradlew test # TODO: Fix unit test errors soon... command: ./gradlew test
- store_artifacts: - store_artifacts:
path: app/build/reports/ path: app/build/reports/
destination: reports destination: reports
......
...@@ -3,6 +3,7 @@ package chat.rocket.android ...@@ -3,6 +3,7 @@ package chat.rocket.android
import chat.rocket.android.server.infraestructure.MemoryMessagesRepository import chat.rocket.android.server.infraestructure.MemoryMessagesRepository
import chat.rocket.core.model.Message import chat.rocket.core.model.Message
import chat.rocket.core.model.MessageType import chat.rocket.core.model.MessageType
import kotlinx.coroutines.experimental.runBlocking
import org.hamcrest.CoreMatchers.notNullValue import org.hamcrest.CoreMatchers.notNullValue
import org.hamcrest.MatcherAssert.assertThat import org.hamcrest.MatcherAssert.assertThat
import org.junit.Before import org.junit.Before
...@@ -30,7 +31,9 @@ class MemoryMessagesRepositoryTest { ...@@ -30,7 +31,9 @@ class MemoryMessagesRepositoryTest {
senderAlias = null, senderAlias = null,
type = MessageType.MessageRemoved(), type = MessageType.MessageRemoved(),
updatedAt = 1511443964815, updatedAt = 1511443964815,
urls = null urls = null,
pinned = false,
reactions = null
) )
val msg2 = Message( val msg2 = Message(
...@@ -50,16 +53,21 @@ class MemoryMessagesRepositoryTest { ...@@ -50,16 +53,21 @@ class MemoryMessagesRepositoryTest {
senderAlias = null, senderAlias = null,
type = MessageType.MessageRemoved(), type = MessageType.MessageRemoved(),
updatedAt = 1511443964818, updatedAt = 1511443964818,
urls = null urls = null,
pinned = false,
reactions = null
) )
@Before @Before
fun setup() { fun setup() {
runBlocking {
repository.clear() repository.clear()
} }
}
@Test @Test
fun `save() should save a single message`() { fun `save() should save a single message`() {
runBlocking {
assertThat(repository.getAll().size, isEqualTo(0)) assertThat(repository.getAll().size, isEqualTo(0))
repository.save(msg) repository.save(msg)
val allMessages = repository.getAll() val allMessages = repository.getAll()
...@@ -70,9 +78,11 @@ class MemoryMessagesRepositoryTest { ...@@ -70,9 +78,11 @@ class MemoryMessagesRepositoryTest {
assertThat(roomId, isEqualTo("GENERAL")) assertThat(roomId, isEqualTo("GENERAL"))
} }
} }
}
@Test @Test
fun `saveAll() should all saved messages`() { fun `saveAll() should all saved messages`() {
runBlocking {
assertThat(repository.getAll().size, isEqualTo(0)) assertThat(repository.getAll().size, isEqualTo(0))
repository.saveAll(listOf(msg, msg2)) repository.saveAll(listOf(msg, msg2))
val allMessages = repository.getAll() val allMessages = repository.getAll()
...@@ -89,9 +99,11 @@ class MemoryMessagesRepositoryTest { ...@@ -89,9 +99,11 @@ class MemoryMessagesRepositoryTest {
assertThat(roomId, isEqualTo("sandbox")) assertThat(roomId, isEqualTo("sandbox"))
} }
} }
}
@Test @Test
fun `getById() should return a single message`() { fun `getById() should return a single message`() {
runBlocking {
repository.saveAll(listOf(msg, msg2)) repository.saveAll(listOf(msg, msg2))
var singleMsg = repository.getById("messageId") var singleMsg = repository.getById("messageId")
assertThat(singleMsg, notNullValue()) assertThat(singleMsg, notNullValue())
...@@ -109,9 +121,11 @@ class MemoryMessagesRepositoryTest { ...@@ -109,9 +121,11 @@ class MemoryMessagesRepositoryTest {
assertThat(roomId, isEqualTo("sandbox")) assertThat(roomId, isEqualTo("sandbox"))
} }
} }
}
@Test @Test
fun `getByRoomId() should return all messages for room id or an empty list`() { fun `getByRoomId() should return all messages for room id or an empty list`() {
runBlocking {
repository.saveAll(listOf(msg, msg2)) repository.saveAll(listOf(msg, msg2))
var roomMessages = repository.getByRoomId("faAad32fkasods2") var roomMessages = repository.getByRoomId("faAad32fkasods2")
assertThat(roomMessages.isEmpty(), isEqualTo(true)) assertThat(roomMessages.isEmpty(), isEqualTo(true))
...@@ -132,4 +146,5 @@ class MemoryMessagesRepositoryTest { ...@@ -132,4 +146,5 @@ class MemoryMessagesRepositoryTest {
assertThat(roomId, isEqualTo("GENERAL")) assertThat(roomId, isEqualTo("GENERAL"))
} }
} }
}
} }
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment