Commit 352f0c01 authored by Yusuke Iwaki's avatar Yusuke Iwaki

respect Google Java style

parent cf7b024b
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0"?>
<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http://www.puppycrawl.com/dtds/configuration_1_3.dtd"> <!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.3//EN"
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
<!--
Checkstyle configuration that checks the Google coding conventions from Google Java Style
that can be found at https://google.github.io/styleguide/javaguide.html.
Checkstyle is very configurable. Be sure to read the documentation at
http://checkstyle.sf.net (or in your downloaded distribution).
To completely disable a check, just comment it out or delete it from the file.
Authors: Max Vetrenko, Ruslan Diachenko, Roman Ivanov.
-->
<module name="Checker"> <module name="Checker">
<property name="severity" value="warning"/>
<property name="charset" value="UTF-8"/> <property name="charset" value="UTF-8"/>
<module name="SuppressionCommentFilter">
<property name="offCommentFormat" value="CHECKSTYLE:OFF (\w+)"/> <property name="severity" value="warning"/>
<property name="onCommentFormat" value="CHECKSTYLE:ON (\w+)"/>
<property name="checkFormat" value="$1"/> <property name="fileExtensions" value="java, properties, xml"/>
</module> <!-- Checks for whitespace -->
<module name="SuppressionFilter"> <!-- See http://checkstyle.sf.net/config_whitespace.html -->
<property name="file" value="config/quality/checkstyle/checkstyle-suppressions.xml"/> <module name="FileTabCharacter">
<property name="eachLine" value="true"/>
</module> </module>
<module name="TreeWalker"> <module name="TreeWalker">
<module name="AvoidStarImport"> <module name="OuterTypeFilename"/>
<property name="severity" value="error"/> <module name="IllegalTokenText">
<property name="excludes" value="org.junit.Assert,org.mockito.Mockito,org.hamcrest.Matchers"/> <property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>
<property name="format"
value="\\u00(08|09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"/>
<property name="message" value="Avoid using corresponding octal or Unicode escape."/>
</module>
<module name="AvoidEscapedUnicodeCharacters">
<property name="allowEscapesForControlCharacters" value="true"/>
<property name="allowByTailComment" value="true"/>
<property name="allowNonPrintableEscapes" value="true"/>
</module> </module>
<module name="IllegalCatch"> <module name="LineLength">
<property name="severity" value="info"/> <property name="max" value="100"/>
<property name="ignorePattern"
value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
</module> </module>
<module name="RedundantImport"> <module name="AvoidStarImport"/>
<message key="import.redundant" value="Redundant import: {0}. Use Ctrl+Shift+O (Eclipse) or Ctrl+Alt+O (Intellij) to sort imports"/> <module name="OneTopLevelClass"/>
<property name="severity" value="error"/> <module name="NoLineWrap"/>
<module name="EmptyBlock">
<property name="option" value="TEXT"/>
<property name="tokens"
value="LITERAL_TRY, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
</module> </module>
<module name="UnusedImports"> <module name="NeedBraces"/>
<message key="import.unused" value="Unused import: {0}. Use Ctrl+Shift+O (Eclipse) or Ctrl+Alt+O (Intellij) to sort imports"/> <module name="LeftCurly">
<property name="severity" value="error"/> <property name="maxLineLength" value="100"/>
<property name="processJavadoc" value="true"/>
</module> </module>
<module name="JavadocType"> <module name="RightCurly"/>
<property name="severity" value="warning"/> <module name="RightCurly">
<property name="tokens" value="INTERFACE_DEF, CLASS_DEF"/> <property name="option" value="alone"/>
<property name="scope" value="public"/> <property name="tokens"
<property name="allowUnknownTags" value="true"/> <!-- Allows @hide tags in JavaDocs --> value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
<message key="javadoc.missing" value="Public classes and interfaces require JavaDoc comments."/>
</module> </module>
<module name="JavadocMethod"> <module name="WhitespaceAround">
<property name="severity" value="error"/> <property name="allowEmptyConstructors" value="true"/>
<property name="scope" value="public"/> <property name="allowEmptyMethods" value="true"/>
<property name="tokens" value="METHOD_DEF"/> <property name="allowEmptyTypes" value="true"/>
<property name="allowMissingParamTags" value="true"/> <property name="allowEmptyLoops" value="true"/>
<property name="allowMissingPropertyJavadoc" value="true"/> <message key="ws.notFollowed"
<property name="allowMissingReturnTag" value="true"/> value="WhitespaceAround: ''{0}'' is not followed by whitespace. Empty blocks may only be represented as '{}' when not part of a multi-block statement (4.1.3)"/>
<property name="allowMissingThrowsTags" value="true"/> <message key="ws.notPreceded"
value="WhitespaceAround: ''{0}'' is not preceded with whitespace."/>
</module>
<module name="OneStatementPerLine"/>
<module name="MultipleVariableDeclarations"/>
<module name="ArrayTypeStyle"/>
<module name="MissingSwitchDefault"/>
<module name="FallThrough"/>
<module name="UpperEll"/>
<module name="ModifierOrder"/>
<module name="EmptyLineSeparator">
<property name="allowNoEmptyLineBetweenFields" value="true"/>
</module> </module>
<module name="PackageName"> <module name="SeparatorWrap">
<property name="severity" value="error"/> <property name="tokens" value="DOT"/>
<property name="format" value="^[a-z]+(\.[a-z][a-z0-9_]{1,})*$"/> <property name="option" value="nl"/>
</module> </module>
<module name="SimplifyBooleanExpression"> <module name="SeparatorWrap">
<property name="severity" value="error"/> <property name="tokens" value="COMMA"/>
<property name="option" value="EOL"/>
</module> </module>
<module name="SimplifyBooleanReturn"> <module name="PackageName">
<property name="severity" value="error"/> <property name="format" value="^[a-z]+(\.[a-z][a-z0-9]*)*$"/>
<message key="name.invalidPattern"
value="Package name ''{0}'' must match pattern ''{1}''."/>
</module> </module>
<module name="TypeName"> <module name="TypeName">
<property name="severity" value="error"/> <message key="name.invalidPattern"
</module> value="Type name ''{0}'' must match pattern ''{1}''."/>
<module name="ConstantName">
<property name="severity" value="error"/>
<property name="format" value="^([A-Z][A-Z0-9]*(_[A-Z0-9]+)*)|(s[A-Z][a-zA-Z0-9]*)$"/>
<message key="name.invalidPattern" value="Static final field names must either be all caps (e.g. int HEIGHT_PX) for 'true' constants, or start with s (e.g. AtomicInteger sNextId or Runnable sSuspendTask) for fields with mutable state or that don't 'feel' like constants."/>
</module> </module>
<!-- Non-public, non-static field names start with m. -->
<module name="MemberName"> <module name="MemberName">
<property name="severity" value="error"/> <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
<property name="format" value="^m[A-Z][a-zA-Z0-9]*$"/> <message key="name.invalidPattern"
<property name="applyToPublic" value="false"/> value="Member name ''{0}'' must match pattern ''{1}''."/>
<message key="name.invalidPattern" value="Non-public, non-static field names start with m."/>
</module>
<!-- Static field names start with s. -->
<module name="StaticVariableName">
<property name="severity" value="error"/>
<property name="format" value="^s[A-Z][a-zA-Z0-9]*$"/>
<property name="applyToPublic" value="false"/>
<message key="name.invalidPattern" value="Static field names start with s."/>
</module>
<module name="MethodName">
<property name="severity" value="error"/>
<property name="format" value="^[a-z][a-zA-Z0-9_]*$"/>
<message key="name.invalidPattern" value="Method names should start with a lower case letter (e.g. getWidth())"/>
</module> </module>
<module name="ParameterName"> <module name="ParameterName">
<property name="severity" value="error"/> <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
<message key="name.invalidPattern"
value="Parameter name ''{0}'' must match pattern ''{1}''."/>
</module> </module>
<module name="LocalFinalVariableName"> <module name="CatchParameterName">
<property name="severity" value="error"/> <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
<property name="format" value="^m|s|((([ms][a-z0-9])|([a-ln-rt-z]))[a-zA-Z0-9]*)$"/> <message key="name.invalidPattern"
<message key="name.invalidPattern" value="Local variables should be camel-cased (e.g. int minWidth = 4)."/> value="Catch parameter name ''{0}'' must match pattern ''{1}''."/>
</module> </module>
<module name="LocalVariableName"> <module name="LocalVariableName">
<property name="severity" value="error"/> <property name="tokens" value="VARIABLE_DEF"/>
<property name="format" value="^m|s|((([ms][a-z0-9])|([a-ln-rt-z]))[a-zA-Z0-9]*)$"/> <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
<message key="name.invalidPattern" value="Local variables should be camel-cased (e.g. int minWidth = 4)."/> <property name="allowOneCharVarInForLoop" value="true"/>
</module> <message key="name.invalidPattern"
<module name="LineLength"> value="Local variable name ''{0}'' must match pattern ''{1}''."/>
<property name="severity" value="error"/> </module>
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/> <module name="ClassTypeParameterName">
<property name="max" value="100"/> <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
</module> <message key="name.invalidPattern"
<module name="LeftCurly"> value="Class type name ''{0}'' must match pattern ''{1}''."/>
<property name="severity" value="error"/> </module>
</module> <module name="MethodTypeParameterName">
<module name="RightCurly"> <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
<property name="severity" value="error"/> <message key="name.invalidPattern"
</module> value="Method type name ''{0}'' must match pattern ''{1}''."/>
<module name="NeedBraces"> </module>
<message key="needBraces" value="if, for, while, and do require curly braces unless they are single-line statements."/> <module name="InterfaceTypeParameterName">
<property name="severity" value="error"/> <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
<property name="tokens" value="LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, LITERAL_IF"/> <message key="name.invalidPattern"
<property name="allowSingleLineStatement" value="true"/> value="Interface type name ''{0}'' must match pattern ''{1}''."/>
</module> </module>
<module name="EmptyBlock"> <module name="NoFinalizer"/>
<property name="severity" value="error"/>
<property name="option" value="text"/>
<metadata name="altname" value="EmptyCatchBlock"/>
</module>
<module name="UpperEll">
<property name="severity" value="error"/>
</module>
<module name="FallThrough">
<property name="severity" value="error"/>
<property name="reliefPattern" value=".*"/>
</module>
<module name="ModifierOrder">
<property name="severity" value="error"/>
</module>
<module name="WhitespaceAround">
<property name="severity" value="error"/>
<property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR, BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN, EQUAL, GE, GT, LAND, LE, LITERAL_ASSERT, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE, LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN, LITERAL_SYNCHRONIZED, LITERAL_TRY, LITERAL_WHILE, LOR, LT, MINUS, MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN, QUESTION, SL, SLIST, SL_ASSIGN, SR, SR_ASSIGN, STAR, STAR_ASSIGN, TYPE_EXTENSION_AND" />
<property name="allowEmptyConstructors" value="true"/>
<property name="allowEmptyMethods" value="true"/>
</module>
<module name="WhitespaceAfter">
<property name="severity" value="error"/>
<property name="tokens" value="COMMA, SEMI, TYPECAST"/>
</module>
<module name="NoWhitespaceAfter">
<property name="severity" value="error"/>
<property name="tokens" value="BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNARY_PLUS"/>
</module>
<module name="NoWhitespaceBefore">
<property name="severity" value="error"/>
<property name="allowLineBreaks" value="true"/>
<property name="tokens" value="SEMI, DOT, POST_DEC, POST_INC"/>
</module>
<module name="GenericWhitespace"> <module name="GenericWhitespace">
<property name="severity" value="error"/>
<message key="ws.followed" <message key="ws.followed"
value="GenericWhitespace ''{0}'' is followed by whitespace."/> value="GenericWhitespace ''{0}'' is followed by whitespace."/>
<message key="ws.preceded" <message key="ws.preceded"
value="GenericWhitespace ''{0}'' is preceded with whitespace."/> value="GenericWhitespace ''{0}'' is preceded with whitespace."/>
<message key="ws.illegalFollow" <message key="ws.illegalFollow"
value="GenericWhitespace ''{0}'' should followed by whitespace."/> value="GenericWhitespace ''{0}'' should followed by whitespace."/>
<message key="ws.notPreceded" <message key="ws.notPreceded"
value="GenericWhitespace ''{0}'' is not preceded with whitespace."/> value="GenericWhitespace ''{0}'' is not preceded with whitespace."/>
</module>
<module name="EmptyStatement">
<property name="severity" value="error"/>
</module>
<module name="NoFinalizer">
<property name="severity" value="info"/>
</module>
<module name="ParenPad">
<property name="severity" value="error"/>
</module>
<module name="MethodParamPad">
<property name="severity" value="error"/>
</module>
<module name="ImportOrder">
<property name="severity" value="error"/>
<message key="import.ordering" value="Wrong order for {0} import. Use Ctrl+Shift+O (Eclipse) or Ctrl+Alt+O (Intellij) to sort imports"/>
<property name="groups" value="android, com.android, dalvik, com, gov, junit, libcore, net, org, java, javax"/>
<property name="ordered" value="true"/>
<property name="option" value="top"/>
<property name="separated" value="true"/>
</module> </module>
<module name="Indentation"> <module name="Indentation">
<property name="severity" value="error"/> <property name="basicOffset" value="2"/>
<property name="basicOffset" value="4"/> <property name="braceAdjustment" value="0"/>
<property name="throwsIndent" value="8"/> <property name="caseIndent" value="2"/>
<property name="lineWrappingIndentation" value="8"/> <property name="throwsIndent" value="4"/>
</module> <property name="lineWrappingIndentation" value="4"/>
<module name="OperatorWrap"> <property name="arrayInitIndent" value="2"/>
<property name="severity" value="error"/> </module>
<property name="option" value="NL" /> <module name="AbbreviationAsWordInName">
<property name="tokens" value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR " /> <property name="ignoreFinal" value="false"/>
</module> <property name="allowedAbbreviationLength" value="1"/>
</module>
<module name="OverloadMethodsDeclarationOrder"/>
<module name="VariableDeclarationUsageDistance"/>
<module name="CustomImportOrder">
<property name="specialImportsRegExp" value="com.google"/>
<property name="sortImportsInGroupAlphabetically" value="true"/>
<property name="customImportOrderRules"
value="STATIC###SPECIAL_IMPORTS###THIRD_PARTY_PACKAGE###STANDARD_JAVA_PACKAGE"/>
</module>
<module name="MethodParamPad"/>
<module name="OperatorWrap"> <module name="OperatorWrap">
<property name="severity" value="error"/> <property name="option" value="NL"/>
<property name="option" value="eol"/> <property name="tokens"
<property name="tokens" value="ASSIGN"/> value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "/>
</module> </module>
<module name="SeparatorWrap"> <module name="AnnotationLocation">
<property name="severity" value="error"/> <property name="tokens" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF"/>
<property name="tokens" value="DOT"/>
<property name="option" value="nl"/>
</module> </module>
<module name="SeparatorWrap"> <module name="AnnotationLocation">
<property name="severity" value="error"/> <property name="tokens" value="VARIABLE_DEF"/>
<property name="tokens" value="COMMA"/> <property name="allowSamelineMultipleAnnotations" value="true"/>
<property name="option" value="EOL"/>
</module>
<module name="MissingDeprecated">
<property name="severity" value="error"/>
</module> </module>
<module name="MissingOverride"> <module name="NonEmptyAtclauseDescription"/>
<property name="severity" value="error"/> <module name="JavadocTagContinuationIndentation"/>
<module name="SummaryJavadoc">
<property name="forbiddenSummaryFragments"
value="^@return the *|^This method returns |^A [{]@code [a-zA-Z0-9]+[}]( is a )"/>
</module> </module>
<module name="OneTopLevelClass"> <module name="JavadocParagraph"/>
<property name="severity" value="error"/> <module name="AtclauseOrder">
<property name="tagOrder" value="@param, @return, @throws, @deprecated"/>
<property name="target"
value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
</module> </module>
<module name="StringLiteralEquality"> <module name="JavadocMethod">
<property name="severity" value="error"/> <property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
<property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
<property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
<property name="allowThrowsTagsForSubclasses" value="true"/>
</module> </module>
<module name="ArrayTypeStyle"> <module name="MethodName">
<property name="severity" value="error"/> <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9_]*$"/>
<message key="name.invalidPattern"
value="Method name ''{0}'' must match pattern ''{1}''."/>
</module> </module>
<module name="RedundantModifier"> <module name="SingleLineJavadoc">
<property name="severity" value="error"/> <property name="ignoreInlineTags" value="false"/>
</module> </module>
<module name="OuterTypeFilename"> <module name="EmptyCatchBlock">
<property name="severity" value="error"/> <property name="exceptionVariableName" value="expected"/>
</module> </module>
<module name="FileContentsHolder"/> <module name="CommentsIndentation"/>
</module>
<module name="FileTabCharacter">
<property name="severity" value="error"/>
</module>
<module name="NewlineAtEndOfFile">
<property name="severity" value="error"/>
</module>
<module name="RegexpSingleline">
<property name="severity" value="error"/>
<property name="format" value="[ \t]+$"/>
<property name="message" value="Trailing whitespace"/>
</module> </module>
</module> </module>
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment