(legacy) refactor status_lb_vs.php

(cherry picked from commit 3752add1)

src/www/status_lb_vs.php

 <?php
 
 /*
-	Copyright (C) 2014-2015 Deciso B.V.
+    Copyright (C) 2014-2016 Deciso B.V.
     Copyright (C) 2010 Seth Mos <seth.mos@dds.nl>.
     All rights reserved.
 
@@ -28,21 +28,37 @@
 */
 
 require_once("guiconfig.inc");
+require_once("filter.inc");
 require_once("services.inc");
 require_once("vslb.inc");
 
-if (!is_array($config['load_balancer']['lbpool'])) {
-	$config['load_balancer']['lbpool'] = array();
+if (empty($config['load_balancer']['lbpool']) || !is_array($config['load_balancer']['lbpool'])) {
+    $a_pool = array();
+} else {
+    $a_pool = &$config['load_balancer']['lbpool'];
 }
-if (!is_array($config['load_balancer']['virtual_server'])) {
-	$config['load_balancer']['virtual_server'] = array();
+if (empty($config['load_balancer']['virtual_server']) || !is_array($config['load_balancer']['virtual_server'])) {
+    $a_vs = array();
+} else {
+    $a_vs = &$config['load_balancer']['virtual_server'];
 }
-$a_vs = &$config['load_balancer']['virtual_server'];
-$a_pool = &$config['load_balancer']['lbpool'];
+
+if ($_SERVER['REQUEST_METHOD'] === 'POST') {
+    if (!empty($_POST['apply'])) {
+        relayd_configure();
+        filter_configure();
+        clear_subsystem_dirty('loadbalancer');
+        header("Location: status_lb_vs.php");
+        exit;
+    }
+}
+
 $rdr_a = get_lb_redirects();
 
 $service_hook = 'relayd';
-
+legacy_html_escape_form_data($a_vs);
+legacy_html_escape_form_data($a_pool);
+legacy_html_escape_form_data($rdr_a);
 include("head.inc");
 
 ?>
@@ -54,53 +70,41 @@ include("head.inc");
   <section class="page-content-main">
     <div class="container-fluid">
       <div class="row">
-
         <?php if (is_subsystem_dirty('loadbalancer')): ?><br/>
         <?php print_info_box_apply(sprintf(gettext("The load balancer configuration has been changed%sYou must apply the changes in order for them to take effect."), "<br />"));?>
         <?php endif; ?>
-
         <section class="col-xs-12">
-
           <div class="tab-content content-box col-xs-12">
             <div class="container-fluid">
-							<form action="status_lb_pool.php" method="post">
               <div class="table-responsive">
-
-
-				              <table class="table table-striped table-sort __nomb">
+                <table class="table table-striped">
                   <thead>
                     <tr>
-				                  <td width="10%" class="listhdrr"><?=gettext("Name"); ?></td>
-						  <td width="20%" class="listhdrr"><?=gettext("Address"); ?></td>
-				                  <td width="10%" class="listhdrr"><?=gettext("Servers"); ?></td>
-				                  <td width="25%" class="listhdrr"><?=gettext("Status"); ?></td>
-				                  <td width="25%" class="listhdr"><?=gettext("Description"); ?></td>
+                      <td><?=gettext("Name"); ?></td>
+                      <td><?=gettext("Address"); ?></td>
+                      <td><?=gettext("Servers"); ?></td>
+                      <td><?=gettext("Status"); ?></td>
+                      <td><?=gettext("Description"); ?></td>
                     </tr>
                   </thead>
                   <tbody>
-							  <?php $i = 0; foreach ($a_vs as $vsent): ?>
+<?php
+                  $i = 0;
+                  foreach ($a_vs as $vsent): ?>
                     <tr>
-				                  <td class="listlr">
-								<?=$vsent['name'];?>
-				                  </td>
-				                  <td class="listr" align="center" >
-				                                <?=$vsent['ipaddr']." : ".$vsent['port'];?>
-				                                <br />
-				                  </td>
-				                  <td class="listr" align="center" >
-							<table border="0" cellpadding="0" cellspacing="2" summary="servers">
-				                        <?php
-							foreach ($a_pool as $vipent) {
-								if ($vipent['name'] == $vsent['poolname']) {
-									foreach ((array) $vipent['servers'] as $server) {
-										print "<tr><td> {$server} </td></tr>";
-									}
-								}
-							}
-							?>
-							</table>
+                      <td><?=$vsent['name'];?></td>
+                      <td><?=$vsent['ipaddr']." : ".$vsent['port'];?></td>
+                      <td>
+<?php
+                        foreach ($a_pool as $vipent):
+                          if ($vipent['name'] == $vsent['poolname']):?>
+
+                          <?=implode('<br/>',$vipent['servers']);?>
+<?php
+                          endif;
+                        endforeach;?>
                       </td>
-				                  <?php
+<?php
                         switch (trim($rdr_a[$vsent['name']]['status'])) {
                           case 'active':
                             $bgcolor = "#90EE90";  // lightgreen
@@ -115,24 +119,19 @@ include("head.inc");
                             $rdr_a[$vsent['name']]['status'] = 'Unknown - relayd not running?';
                         }
                         ?>
-				                  <td class="listr nowrap">
+                      <td>
                         <table border="0" cellpadding="3" cellspacing="2" summary="status">
                           <tr><td bgcolor="<?=$bgcolor?>"><?=$rdr_a[$vsent['name']]['status']?> </td></tr>
                         </table>
-							<?php
-							if (!empty($rdr_a[$vsent['name']]['total']))
-								echo "Total Sessions: {$rdr_a[$vsent['name']]['total']}\n";
-							if (!empty($rdr_a[$vsent['name']]['last']))
-								echo "<br />Last: {$rdr_a[$vsent['name']]['last']}\n";
-							if (!empty($rdr_a[$vsent['name']]['average']))
-								echo "<br />Average: {$rdr_a[$vsent['name']]['average']}\n";
-							?>
-				                  </td>
-				                  <td class="listbg" >
-										<?=$vsent['descr'];?>
+                        <?=!empty($rdr_a[$vsent['name']]['total']) ?  "Total Sessions: {$rdr_a[$vsent['name']]['total']}" : "";?>
+                        <?=!empty($rdr_a[$vsent['name']]['last']) ? "<br />Last: {$rdr_a[$vsent['name']]['last']}" : "";?>
+                        <?=!empty($rdr_a[$vsent['name']]['average']) ? "<br />Average: {$rdr_a[$vsent['name']]['average']}" : "";?>
                       </td>
+                      <td><?=$vsent['descr'];?></td>
                     </tr>
-						<?php $i++; endforeach; ?>
+<?php
+                    $i++;
+                  endforeach; ?>
                   </tbody>
                 </table>
               </div>
@@ -142,5 +141,4 @@ include("head.inc");
       </div>
     </div>
   </section>
-
 <?php include("foot.inc"); ?>