Skip to content

O
OpnSense
Commit f4fcce27 authored by Ad Schellevis's avatar Ad Schellevis
Browse files
Options

(legacy) refactor services_wol_edit.php

parent 4a973535
Show whitespace changes
Inline Side-by-side
Showing with 151 additions and 163 deletions
src/www/services_wol_edit.php
View file @ f4fcce27
<?php <?php
/* /*
Copyright (C) 2014-2015 Deciso B.V. Copyright (C) 2014-2016 Deciso B.V.
Copyright (C) 2003-2004 Manuel Kasper <mk@neon1.net>. Copyright (C) 2003-2004 Manuel Kasper <mk@neon1.net>.
All rights reserved. All rights reserved.
...@@ -27,76 +27,65 @@ ...@@ -27,76 +27,65 @@
POSSIBILITY OF SUCH DAMAGE. POSSIBILITY OF SUCH DAMAGE.
*/ */
require_once("guiconfig.inc");
require_once("interfaces.inc");
function wolcmp($a, $b) { function wolcmp($a, $b) {
return strcmp($a['descr'], $b['descr']); return strcmp($a['descr'], $b['descr']);
} }
function wol_sort() {
global $config;
usort($config['wol']['wolentry'], "wolcmp"); if (empty($config['wol']['wolentry']) || !is_array($config['wol']['wolentry'])) {
}
require_once("guiconfig.inc");
require_once("interfaces.inc");
$referer = (isset($_SERVER['HTTP_REFERER']) ? $_SERVER['HTTP_REFERER'] : '/services_wol.php');
if (!isset($config['wol']) || !is_array($config['wol'])) {
$config['wol'] = array(); $config['wol'] = array();
}
if (!is_array($config['wol']['wolentry'])) {
$config['wol']['wolentry'] = array(); $config['wol']['wolentry'] = array();
} }
$a_wol = &$config['wol']['wolentry']; $a_wol = &$config['wol']['wolentry'];
if (is_numericint($_GET['id'])) if ($_SERVER['REQUEST_METHOD'] === 'GET') {
if (isset($_GET['id']) && !empty($a_wol[$_GET['id']])) {
$id = $_GET['id']; $id = $_GET['id'];
if (isset($_POST['id']) && is_numericint($_POST['id'])) }
$pconfig = array();
foreach (array('interface', 'mac', 'descr') as $fieldname) {
if (isset($id) && isset($a_wol[$id][$fieldname])) {
$pconfig[$fieldname] = $a_wol[$id][$fieldname];
} elseif (isset($_GET[$fieldname])) {
$pconfig[$fieldname] = $_GET[$fieldname];
} else {
$pconfig[$fieldname] = null;
}
}
} elseif ($_SERVER['REQUEST_METHOD'] === 'POST') {
if (isset($_POST['id']) && !empty($a_wol[$_POST['id']])) {
$id = $_POST['id']; $id = $_POST['id'];
}
if (isset($id) && $a_wol[$id]) {
$pconfig['interface'] = $a_wol[$id]['interface'];
$pconfig['mac'] = $a_wol[$id]['mac'];
$pconfig['descr'] = $a_wol[$id]['descr'];
}
else
{
$pconfig['interface'] = $_GET['if'];
$pconfig['mac'] = $_GET['mac'];
$pconfig['descr'] = $_GET['descr'];
}
if ($_POST) {
unset($input_errors);
$pconfig = $_POST; $pconfig = $_POST;
$input_errors = array();
/* input validation */ /* input validation */
$reqdfields = explode(" ", "interface mac"); $reqdfields = explode(" ", "interface mac");
$reqdfieldsn = array(gettext("Interface"),gettext("MAC address")); $reqdfieldsn = array(gettext("Interface"),gettext("MAC address"));
do_input_validation($_POST, $reqdfields, $reqdfieldsn, $input_errors); do_input_validation($pconfig, $reqdfields, $reqdfieldsn, $input_errors);
/* normalize MAC addresses - lowercase and convert Windows-ized hyphenated MACs to colon delimited */ /* normalize MAC addresses - lowercase and convert Windows-ized hyphenated MACs to colon delimited */
$_POST['mac'] = strtolower(str_replace("-", ":", $_POST['mac'])); $pconfig['mac'] = strtolower(str_replace("-", ":", $pconfig['mac']));
if (($_POST['mac'] && !is_macaddr($_POST['mac']))) { if (!empty($pconfig['mac']) && !is_macaddr($_POST['mac'])) {
$input_errors[] = gettext("A valid MAC address must be specified."); $input_errors[] = gettext("A valid MAC address must be specified.");
} }
if (count($input_errors) == 0) {
if (!$input_errors) {
$wolent = array(); $wolent = array();
$wolent['interface'] = $_POST['interface']; $wolent['interface'] = $_POST['interface'];
$wolent['mac'] = $_POST['mac']; $wolent['mac'] = $_POST['mac'];
$wolent['descr'] = $_POST['descr']; $wolent['descr'] = $_POST['descr'];
if (isset($id) && $a_wol[$id]) if (isset($id)) {
$a_wol[$id] = $wolent; $a_wol[$id] = $wolent;
else } else {
$a_wol[] = $wolent; $a_wol[] = $wolent;
wol_sort(); }
usort($config['wol']['wolentry'], "wolcmp");
write_config(); write_config();
header("Location: services_wol.php"); header("Location: services_wol.php");
...@@ -105,69 +94,70 @@ if ($_POST) { ...@@ -105,69 +94,70 @@ if ($_POST) {
} }
include("head.inc"); include("head.inc");
legacy_html_escape_form_data($pconfig);
?> ?>
<body> <body>
<?php include("fbegin.inc"); ?> <?php include("fbegin.inc"); ?>
<section class="page-content-main"> <section class="page-content-main">
<div class="container-fluid"> <div class="container-fluid">
<div class="row"> <div class="row">
<?php if (isset($input_errors) && count($input_errors) > 0) print_input_errors($input_errors); ?> <?php if (isset($input_errors) && count($input_errors) > 0) print_input_errors($input_errors); ?>
<section class="col-xs-12"> <section class="col-xs-12">
<div class="content-box"> <div class="content-box">
<form method="post" name="iform" id="iform">
<header class="content-box-head container-fluid">
<h3><?=gettext("Edit WOL entry");?></h3>
</header>
<div class="content-box-main col-xs-12">
<form action="services_wol_edit.php" method="post" name="iform" id="iform">
<div class="table-responsive"> <div class="table-responsive">
<table class="table table-striped table-sort"> <table class="table table-striped">
<tr>
<td width="22%">
<strong><?=gettext("Edit WOL entry");?></strong>
</td>
<td width="78%" align="right">
<small><?=gettext("full help"); ?> </small>
<i class="fa fa-toggle-off text-danger" style="cursor: pointer;" id="show_all_help_page"></i>
</td>
</tr>
<tr> <tr>
<td width="22%" valign="top" class="vncellreq"><?=gettext("Interface");?></td> <td><a id="help_for_interface" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("Interface");?></td>
<td width="78%" class="vtable"> <td>
<select name="interface" class="formfld"> <select name="interface" class="selectpicker">
<?php <?php
$interfaces = get_configured_interface_with_descr(); foreach (get_configured_interface_with_descr() as $iface => $ifacename): ?>
foreach ($interfaces as $iface => $ifacename): ?> <option value="<?=$iface;?>" <?= !link_interface_to_bridge($iface) && $iface == $pconfig['interface'] ? "selected=\"selected\"" : ""; ?>>
<option value="<?=$iface;?>" <?php if (!link_interface_to_bridge($iface) && $iface == $pconfig['interface']) echo "selected=\"selected\""; ?>>
<?=htmlspecialchars($ifacename);?> <?=htmlspecialchars($ifacename);?>
</option> </option>
<?php endforeach; ?> <?php
</select> <br /> endforeach; ?>
<span class="vexpl"><?=gettext("Choose which interface this host is connected to.");?></span></td> </select>
<div class="hidden" for="help_for_interface">
<?=gettext("Choose which interface this host is connected to.");?>
</div>
</td>
</tr> </tr>
<tr> <tr>
<td width="22%" valign="top" class="vncellreq"><?=gettext("MAC address");?></td> <td><a id="help_for_mac" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("MAC address");?></td>
<td width="78%" class="vtable"> <td>
<input name="mac" type="text" class="formfld" id="mac" size="20" value="<?=htmlspecialchars($pconfig['mac']);?>" /> <input name="mac" type="text" value="<?=$pconfig['mac'];?>" />
<br /> <div class="hidden" for="help_for_mac">
<span class="vexpl"><?=gettext("Enter a MAC address in the following format: ". <?=gettext("Enter a MAC address in the following format: xx:xx:xx:xx:xx:xx");?>
"xx:xx:xx:xx:xx:xx");?></span></td> </div>
</td>
</tr> </tr>
<tr> <tr>
<td width="22%" valign="top" class="vncell"><?=gettext("Description");?></td> <td><a id="help_for_descr" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("Description");?></td>
<td width="78%" class="vtable"> <td>
<input name="descr" type="text" class="formfld" id="descr" size="40" value="<?=htmlspecialchars($pconfig['descr']);?>" /> <input name="descr" type="text" value="<?=$pconfig['descr'];?>" />
<br /> <span class="vexpl"><?=gettext("You may enter a description here". <div class="hidden" for="help_for_descr">
" for your reference (not parsed).");?></span></td> <?=gettext("You may enter a description here for your reference (not parsed).");?>
</div>
</td>
</tr> </tr>
<tr> <tr>
<td width="22%" valign="top">&nbsp;</td> <td>&nbsp;</td>
<td width="78%"> <td>
<input name="Submit" type="submit" class="btn btn-primary" value="<?=gettext("Save");?>" /> <input name="Submit" type="submit" class="btn btn-primary" value="<?=gettext("Save");?>" />
<input type="button" class="btn btn-default" value="<?=gettext("Cancel");?>" onclick="window.location.href='<?=$referer;?>'" /> <input type="button" class="btn btn-default" value="<?=gettext("Cancel");?>" onclick="window.location.href='<?=(isset($_SERVER['HTTP_REFERER']) ? $_SERVER['HTTP_REFERER'] : '/services_wol.php');?>'" />
<?php if (isset($id) && $a_wol[$id]): ?> <?php if (isset($id)): ?>
<input name="id" type="hidden" value="<?=htmlspecialchars($id);?>" /> <input name="id" type="hidden" value="<?=htmlspecialchars($id);?>" />
<?php endif; ?> <?php endif; ?>
</td> </td>
...@@ -176,10 +166,8 @@ include("head.inc"); ...@@ -176,10 +166,8 @@ include("head.inc");
</div> </div>
</form> </form>
</div> </div>
</div>
</section> </section>
</div> </div>
</div> </div>
</section> </section>
<?php include("foot.inc"); ?> <?php include("foot.inc"); ?>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

Technounit-GROUP 2023