Skip to content

O
OpnSense
Commit 9e4138c4 authored by Ad Schellevis's avatar Ad Schellevis
Browse files
Options

(legacy) refactor interfaces_lagg_edit.php

parent 7779d193
Hide whitespace changes
Inline Side-by-side
Showing with 253 additions and 232 deletions
src/www/interfaces_lagg_edit.php
View file @ 9e4138c4
<?php <?php
/* /*
Copyright (C) 2014-2015 Deciso B.V. Copyright (C) 2014-2016 Deciso B.V.
Copyright (C) 2008 Ermal Luçi Copyright (C) 2008 Ermal Luçi
All rights reserved. All rights reserved.
Redistribution and use in source and binary forms, with or without Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met: modification, are permitted provided that the following conditions are met:
1. Redistributions of source code must retain the above copyright notice, 1. Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer. this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright 2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution. documentation and/or other materials provided with the distribution.
THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE. POSSIBILITY OF SUCH DAMAGE.
*/ */
require_once("guiconfig.inc"); require_once("guiconfig.inc");
...@@ -35,226 +35,247 @@ require_once("openvpn.inc"); ...@@ -35,226 +35,247 @@ require_once("openvpn.inc");
require_once("unbound.inc"); require_once("unbound.inc");
require_once("services.inc"); require_once("services.inc");
$referer = (isset($_SERVER['HTTP_REFERER']) ? $_SERVER['HTTP_REFERER'] : '/interfaces_lagg.php'); /**
* list available interfaces for lagg
if (!isset($config['laggs']['lagg'])) { * @param null $selected_id selected item index
$config['laggs']['lagg'] = array(); * @return array
} */
function available_interfaces($selected_id=null)
$a_laggs = &$config['laggs']['lagg']; {
global $config;
$portlist = get_interface_list(); // configured interfaces
$configured_interfaces = array();
$realifchecklist = array(); foreach (get_configured_interface_list(false, true) as $intf) {
/* add LAGG interfaces */ $configured_interfaces[] = get_real_interface($intf);
if (is_array($config['laggs']['lagg']) && count($config['laggs']['lagg'])) { }
foreach ($config['laggs']['lagg'] as $lagg) { // lagg members from other lagg interfaces
unset($portlist[$lagg['laggif']]); $lagg_member_interfaces = array();
$laggiflist = explode(",", $lagg['members']); foreach ($config['laggs']['lagg'] as $lagg_idx => $lagg) {
foreach ($laggiflist as $tmpif) if ($lagg_idx == $selected_id) {
$realifchecklist[get_real_interface($tmpif)] = $tmpif; continue;
} }
foreach (explode(",", $lagg['members']) as $lagg_member) {
$lagg_member_interfaces[] = get_real_interface($lagg_member);
}
}
$interfaces = array();
foreach (get_interface_list() as $intf => $intf_info) {
if (strpos($intf, '_vlan')) {
// skip vlans
continue;
} elseif (in_array($intf, $lagg_member_interfaces)) {
// skip members of other lagg interfaces
continue;
} elseif (in_array($intf, $configured_interfaces)) {
// skip configured interfaces
continue;
}
$interfaces[$intf] = $intf_info;
}
return $interfaces;
} }
$checklist = get_configured_interface_list(false, true);
foreach ($checklist as $tmpif)
$realifchecklist[get_real_interface($tmpif)] = $tmpif;
$laggprotos = array("none", "lacp", "failover", "fec", "loadbalance", "roundrobin"); $laggprotos = array("none", "lacp", "failover", "fec", "loadbalance", "roundrobin");
if (is_numericint($_GET['id'])) if (!isset($config['laggs']['lagg'])) {
$id = $_GET['id']; $config['laggs']['lagg'] = array();
if (isset($_POST['id']) && is_numericint($_POST['id']))
$id = $_POST['id'];
if (isset($id) && $a_laggs[$id]) {
$pconfig['laggif'] = $a_laggs[$id]['laggif'];
$pconfig['members'] = $a_laggs[$id]['members'];
$laggiflist = explode(",", $a_laggs[$id]['members']);
foreach ($laggiflist as $tmpif)
unset($realifchecklist[get_real_interface($tmpif)]);
$pconfig['proto'] = $a_laggs[$id]['proto'];
$pconfig['descr'] = $a_laggs[$id]['descr'];
} }
$a_laggs = &$config['laggs']['lagg'];
if ($_POST) {
unset($input_errors);
$pconfig = $_POST;
/* input validation */
$reqdfields = explode(" ", "members proto");
$reqdfieldsn = array(gettext("Member interfaces"), gettext("Lagg protocol"));
do_input_validation($_POST, $reqdfields, $reqdfieldsn, $input_errors);
if (is_array($_POST['members'])) {
foreach ($_POST['members'] as $member) {
if (!does_interface_exist($member))
$input_errors[] = gettext("Interface supplied as member is invalid");
}
} else if (!does_interface_exist($_POST['members']))
$input_errors[] = gettext("Interface supplied as member is invalid");
if (!in_array($_POST['proto'], $laggprotos))
$input_errors[] = gettext("Protocol supplied is invalid");
if (!$input_errors) {
$lagg = array();
$lagg['members'] = implode(',', $_POST['members']);
$lagg['descr'] = $_POST['descr'];
$lagg['laggif'] = $_POST['laggif'];
$lagg['proto'] = $_POST['proto'];
if (isset($id) && $a_laggs[$id])
$lagg['laggif'] = $a_laggs[$id]['laggif'];
$lagg['laggif'] = interface_lagg_configure($lagg);
if ($lagg['laggif'] == "" || !stristr($lagg['laggif'], "lagg"))
$input_errors[] = gettext("Error occurred creating interface, please retry.");
else {
if (isset($id) && $a_laggs[$id])
$a_laggs[$id] = $lagg;
else
$a_laggs[] = $lagg;
write_config();
$confif = convert_real_interface_to_friendly_interface_name($lagg['laggif']);
if ($confif <> "")
interface_configure($confif);
header("Location: interfaces_lagg.php"); if ($_SERVER['REQUEST_METHOD'] === 'GET') {
exit; // read form data
} if (!empty($a_laggs[$_GET['id']])) {
} $id = $_GET['id'];
}
$pconfig = array();
$pconfig['laggif'] = isset($a_laggs[$id]['laggif']) ? $a_laggs[$id]['laggif'] : null;
$pconfig['members'] = isset($a_laggs[$id]['members']) ? explode(",", $a_laggs[$id]['members']) : array();
$pconfig['proto'] = isset($a_laggs[$id]['proto']) ? $a_laggs[$id]['proto'] : null;
$pconfig['descr'] = isset($a_laggs[$id]['descr']) ? $a_laggs[$id]['descr'] : null;
} elseif ($_SERVER['REQUEST_METHOD'] === 'POST') {
// validate and save form data
if (!empty($a_laggs[$_POST['id']])) {
$id = $_POST['id'];
}
$input_errors = array();
$pconfig = $_POST;
/* input validation */
$reqdfields = explode(" ", "members proto");
$reqdfieldsn = array(gettext("Member interfaces"), gettext("Lagg protocol"));
do_input_validation($pconfig, $reqdfields, $reqdfieldsn, $input_errors);
foreach ($pconfig['members'] as $member) {
if (!does_interface_exist($member)) {
$input_errors[] = gettext("Interface supplied as member is invalid");
}
}
if (!in_array($pconfig['proto'], $laggprotos)) {
$input_errors[] = gettext("Protocol supplied is invalid");
}
if (count($input_errors) == 0) {
$lagg = array();
$lagg['members'] = implode(',', $pconfig['members']);
$lagg['descr'] = $pconfig['descr'];
$lagg['laggif'] = $pconfig['laggif'];
$lagg['proto'] = $pconfig['proto'];
if (isset($id)) {
$lagg['laggif'] = $a_laggs[$id]['laggif'];
}
$lagg['laggif'] = interface_lagg_configure($lagg);
if ($lagg['laggif'] == "" || !stristr($lagg['laggif'], "lagg")) {
$input_errors[] = gettext("Error occurred creating interface, please retry.");
} else {
if (isset($id)) {
$a_laggs[$id] = $lagg;
} else {
$a_laggs[] = $lagg;
}
write_config();
$confif = convert_real_interface_to_friendly_interface_name($lagg['laggif']);
if ($confif <> "") {
interface_configure($confif);
}
header("Location: interfaces_lagg.php");
exit;
}
}
} }
include("head.inc"); include("head.inc");
legacy_html_escape_form_data($pconfig);
?> ?>
<body> <body>
<?php include("fbegin.inc"); ?> <?php include("fbegin.inc"); ?>
<section class="page-content-main">
<div class="container-fluid">
<section class="page-content-main"> <div class="row">
<div class="container-fluid"> <?php if (isset($input_errors) && count($input_errors) > 0) print_input_errors($input_errors); ?>
<div class="row"> <section class="col-xs-12">
<div class="content-box">
<?php if (isset($input_errors) && count($input_errors) > 0) print_input_errors($input_errors); ?> <div class="table-responsive">
<div id="inputerrors"></div> <form method="post" name="iform" id="iform">
<table class="table table-striped">
<thead>
<section class="col-xs-12"> <tr>
<td width="22%"><strong><?=gettext("LAGG configuration");?></strong></td>
<div class="content-box"> <td width="78%" align="right">
<small><?=gettext("full help"); ?> </small>
<header class="content-box-head container-fluid"> <i class="fa fa-toggle-off text-danger" style="cursor: pointer;" id="show_all_help_page" type="button"></i></a>
<h3><?=gettext("LAGG configuration");?></h3> &nbsp;
</header> </td>
</tr>
<div class="content-box-main"> </thead>
<tbody>
<form action="interfaces_lagg_edit.php" method="post" name="iform" id="iform"> <tr>
<table class="table table-striped table-sort"> <td><a id="help_for_members" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("Parent interface"); ?></td>
<tr> <td>
<td width="22%" valign="top" class="vncellreq"><?=gettext("Parent interface"); ?></td> <select name="members[]" multiple="multiple" class="selectpicker">
<td width="78%" class="vtable"> <?php
<select name="members[]" multiple="multiple" size="4" class="selectpicker"> foreach (available_interfaces(isset($id) ? $id : null) as $ifn => $ifinfo):?>
<?php <option value="<?=$ifn;?>" <?=in_array($ifn, $pconfig['members']) ? "selected=\"selected\"" : "";?>>
foreach ($portlist as $ifn => $ifinfo) { <?=$ifn;?> (<?=$ifinfo['mac']?>)
if (array_key_exists($ifn, $realifchecklist)) </option>
continue; <?php
echo "<option value=\"{$ifn}\""; endforeach;?>
if (stristr($pconfig['members'], $ifn)) </select>
echo " selected=\"selected\""; <div class="hidden" for="help_for_members">
echo ">". $ifn ."(".$ifinfo['mac'] .")</option>"; <?=gettext("Choose the members that will be used for the link aggregation"); ?>
} </div>
?> </td>
</select> </tr>
<br /> <tr>
<span class="vexpl"><?=gettext("Choose the members that will be used for the link aggregation"); ?>.</span></td> <td><a id="help_for_proto" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("Lag proto"); ?></td>
</tr> <td>
<tr> <select name="proto" class="selectpicker" id="proto">
<td valign="top" class="vncellreq"><?=gettext("Lag proto"); ?></td> <?php
<td class="vtable"> foreach ($laggprotos as $proto):?>
<select name="proto" class="selectpicker" id="proto"> <option value="<?=$proto;?>" <?=$proto == $pconfig['proto'] ? "selected=\"selected\"": "";?>>
<?php <?=strtoupper($proto);?>
foreach ($laggprotos as $proto) { </option>
echo "<option value=\"{$proto}\""; <?php
if ($proto == $pconfig['proto']) endforeach;?>
echo " selected=\"selected\""; </select>
echo ">".strtoupper($proto)."</option>"; <div class="hidden" for="help_for_proto">
} <ul>
?> <li><b><?=gettext("failover"); ?></b></li>
</select> <?=gettext("Sends and receives traffic only through the master port. If " .
<br /> "the master port becomes unavailable, the next active port is " .
<ul class="vexpl"> "used. The first interface added is the master port; any " .
<li> "interfaces added after that are used as failover devices."); ?>
<b><?=gettext("failover"); ?></b><br /> <li><b><?=gettext("fec"); ?></b><br /></li>
<?=gettext("Sends and receives traffic only through the master port. If " . <?=gettext("Supports Cisco EtherChannel. This is a static setup and " .
"the master port becomes unavailable, the next active port is " . "does not negotiate aggregation with the peer or exchange " .
"used. The first interface added is the master port; any " . "frames to monitor the link."); ?>
"interfaces added after that are used as failover devices."); ?> <li>
</li><li> <b><?=gettext("lacp"); ?></b></li>
<b><?=gettext("fec"); ?></b><br /> <?=gettext("Supports Cisco EtherChannel. This is a static setup and " . <?=gettext("Supports the IEEE 802.3ad Link Aggregation Control Protocol " .
"does not negotiate aggregation with the peer or exchange " . "(LACP) and the Marker Protocol. LACP will negotiate a set " .
"frames to monitor the link."); ?> "of aggregable links with the peer in to one or more Link " .
</li><li> "Aggregated Groups. Each LAG is composed of ports of the " .
<b><?=gettext("lacp"); ?></b><br /> <?=gettext("Supports the IEEE 802.3ad Link Aggregation Control Protocol " . "same speed, set to full-duplex operation. The traffic will " .
"(LACP) and the Marker Protocol. LACP will negotiate a set " . "be balanced across the ports in the LAG with the greatest " .
"of aggregable links with the peer in to one or more Link " . "total speed, in most cases there will only be one LAG which " .
"Aggregated Groups. Each LAG is composed of ports of the " . "contains all ports. In the event of changes in physical " .
"same speed, set to full-duplex operation. The traffic will " . "connectivity, Link Aggregation will quickly converge to a " .
"be balanced across the ports in the LAG with the greatest " . "new configuration."); ?>
"total speed, in most cases there will only be one LAG which " . <li><b><?=gettext("loadbalance"); ?></b></li>
"contains all ports. In the event of changes in physical " . <?=gettext("Balances outgoing traffic across the active ports based on " .
"connectivity, Link Aggregation will quickly converge to a " . "hashed protocol header information and accepts incoming " .
"new configuration."); ?> "traffic from any active port. This is a static setup and " .
</li><li> "does not negotiate aggregation with the peer or exchange " .
<b><?=gettext("loadbalance"); ?></b><br /> <?=gettext("Balances outgoing traffic across the active ports based on " . "frames to monitor the link. The hash includes the Ethernet " .
"hashed protocol header information and accepts incoming " . "source and destination address, and, if available, the VLAN " .
"traffic from any active port. This is a static setup and " . "tag, and the IP source and destination address") ?>.
"does not negotiate aggregation with the peer or exchange " . <li><b><?=gettext("roundrobin"); ?></b></li>
"frames to monitor the link. The hash includes the Ethernet " . <?=gettext("Distributes outgoing traffic using a round-robin scheduler " .
"source and destination address, and, if available, the VLAN " . "through all active ports and accepts incoming traffic from " .
"tag, and the IP source and destination address") ?>. "any active port"); ?>.
</li><li> <li><b><?=gettext("none"); ?></b></li>
<b><?=gettext("roundrobin"); ?></b><br /> <?=gettext("Distributes outgoing traffic using a round-robin scheduler " . <?=gettext("This protocol is intended to do nothing: it disables any " .
"through all active ports and accepts incoming traffic from " . "traffic without disabling the lagg interface itself"); ?>.
"any active port"); ?>.
</li><li> </ul>
<b><?=gettext("none"); ?></b><br /> <?=gettext("This protocol is intended to do nothing: it disables any " . </div>
"traffic without disabling the lagg interface itself"); ?>. </td>
</li> </tr>
</ul> <tr>
</td> <td><a id="help_for_descr" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("Description"); ?></td>
</tr> <td>
<tr> <input name="descr" type="text" value="<?=$pconfig['descr'];?>" />
<td width="22%" valign="top" class="vncell"><?=gettext("Description"); ?></td> <div class="hidden" for="help_for_descr">
<td width="78%" class="vtable"> <?=gettext("You may enter a description here " .
<input name="descr" type="text" class="form-control unknown" id="descr" size="40" value="<?=htmlspecialchars($pconfig['descr']);?>" /> "for your reference (not parsed)."); ?>
<br /> <span class="vexpl"><?=gettext("You may enter a description here " . </div>
"for your reference (not parsed)"); ?>.</span></td> </td>
</tr> </tr>
<tr> <tr>
<td width="22%" valign="top">&nbsp;</td> <td width="22%" valign="top">&nbsp;</td>
<td width="78%"> <td width="78%">
<input type="hidden" name="laggif" value="<?=htmlspecialchars($pconfig['laggif']); ?>" /> <input type="hidden" name="laggif" value="<?=$pconfig['laggif']; ?>" />
<input name="Submit" type="submit" class="btn btn-primary" value="<?=gettext("Save"); ?>" /> <input name="Submit" type="submit" class="btn btn-primary" value="<?=gettext("Save"); ?>" />
<input type="button" class="btn btn-default" value="<?=gettext("Cancel");?>" onclick="window.location.href='<?=$referer;?>'" /> <input type="button" class="btn btn-default" value="<?=gettext("Cancel");?>" onclick="window.location.href='<?=(isset($_SERVER['HTTP_REFERER']) ? $_SERVER['HTTP_REFERER'] : '/interfaces_lagg.php');?>'" />
<?php if (isset($id) && $a_laggs[$id]): ?> <?php if (isset($id)): ?>
<input name="id" type="hidden" value="<?=htmlspecialchars($id);?>" /> <input name="id" type="hidden" value="<?=$id;?>" />
<?php endif; ?> <?php endif; ?>
</td> </td>
</tr> </tr>
</table> </tbody>
</form> </table>
</div> </form>
</div> </div>
</section> </div>
</div> </section>
</div> </div>
</section> </div>
</section>
<?php include("foot.inc"); ?> <?php include("foot.inc"); ?>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

Technounit-GROUP 2023