(systemhealth) don't generate crash report on empty or invalid rrd xml data

(cherry picked from commit 5e4a0073)

(systemhealth) don't generate crash report on empty or invalid rrd xml data
(cherry picked from commit 5e4a0073)
9d97d54a · Ad Schellevis · Franco Fichtner · 1a30913f · 9d97d54a
Commit 9d97d54a authored Apr 11, 2016 by Ad Schellevis Committed by Franco Fichtner Apr 12, 2016
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 4 deletions

SystemhealthController.php ...llers/OPNsense/Diagnostics/Api/SystemhealthController.php +2 -4

No files found.
--- a/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/SystemhealthController.php
+++ b/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/SystemhealthController.php
@@ -542,13 +542,11 @@ class SystemhealthController extends ApiControllerBase
         */

        $rrd_details=$this->getRRDdetails($rrd)["data"];
-
+        $xml = false;
        if ($rrd_details['filename'] != "") {
            $backend = new Backend();
            $response = $backend->configdpRun("systemhealth fetch ", array($rrd_details['filename']));
-            $xml = simplexml_load_string($response);
-        } else {
-            $xml = false;
+            $xml = @simplexml_load_string($response);
        }

        if ($xml !== false) {