dynamic dns: pluggable ACLs, consolidation...

* RFC2136 missed the edit page completely
* DynDNS ACLs merged, we do it by feature

plist

@@ -445,6 +445,7 @@
 /usr/local/opnsense/mvc/app/models/OPNsense/Diagnostics/Netflow.php
 /usr/local/opnsense/mvc/app/models/OPNsense/Diagnostics/Netflow.xml
 /usr/local/opnsense/mvc/app/models/OPNsense/Dnsmasq/Menu/Menu.xml
+/usr/local/opnsense/mvc/app/models/OPNsense/DynamicDNS/ACL/ACL.xml
 /usr/local/opnsense/mvc/app/models/OPNsense/DynamicDNS/Menu/Menu.xml
 /usr/local/opnsense/mvc/app/models/OPNsense/IDS/ACL/ACL.xml
 /usr/local/opnsense/mvc/app/models/OPNsense/IDS/IDS.php
@@ -458,6 +459,7 @@
 /usr/local/opnsense/mvc/app/models/OPNsense/Proxy/Migrations/M1_0_0.php
 /usr/local/opnsense/mvc/app/models/OPNsense/Proxy/Proxy.php
 /usr/local/opnsense/mvc/app/models/OPNsense/Proxy/Proxy.xml
+/usr/local/opnsense/mvc/app/models/OPNsense/RFC2136/ACL/ACL.xml
 /usr/local/opnsense/mvc/app/models/OPNsense/RFC2136/Menu/Menu.xml
 /usr/local/opnsense/mvc/app/models/OPNsense/TrafficShaper/ACL/ACL.xml
 /usr/local/opnsense/mvc/app/models/OPNsense/TrafficShaper/Menu/Menu.xml

src/opnsense/mvc/app/models/OPNsense/Core/ACL/ACL.xml

@@ -551,24 +551,6 @@
             <pattern>services_unbound_host_edit.php*</pattern>
         </patterns>
     </page-services-dnsresolver-edithost>
-    <page-services-dynamicdnsclient>
-        <name>Services: Dynamic DNS client</name>
-        <patterns>
-            <pattern>services_dyndns_edit.php*</pattern>
-        </patterns>
-    </page-services-dynamicdnsclient>
-    <page-services-dynamicdnsclients>
-        <name>Services: Dynamic DNS clients</name>
-        <patterns>
-            <pattern>services_dyndns.php*</pattern>
-        </patterns>
-    </page-services-dynamicdnsclients>
-    <page-services-rfc2136clients>
-        <name>Services: RFC 2136 clients</name>
-        <patterns>
-            <pattern>services_rfc2136.php*</pattern>
-        </patterns>
-    </page-services-rfc2136clients>
     <page-services-router-advertisements>
         <name>Services: Router advertisements</name>
         <patterns>

src/opnsense/mvc/app/models/OPNsense/DynamicDNS/ACL/ACL.xml

+<acl>
+    <page-services-dynamicdnsclients>
+        <name>Services: Dynamic DNS clients</name>
+        <patterns>
+            <pattern>services_dyndns.php*</pattern>
+            <pattern>services_dyndns_edit.php*</pattern>
+        </patterns>
+    </page-services-dynamicdnsclients>
+</acl>

src/opnsense/mvc/app/models/OPNsense/RFC2136/ACL/ACL.xml

+<acl>
+    <page-services-rfc2136clients>
+        <name>Services: RFC 2136 clients</name>
+        <patterns>
+            <pattern>services_rfc2136.php*</pattern>
+            <pattern>services_rfc2136_edit.php*</pattern>
+        </patterns>
+    </page-services-rfc2136clients>
+</acl>