(mvc) small changes for https://github.com/opnsense/core/pull/789

src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkField.php

@@ -67,7 +67,11 @@ class NetworkField extends BaseField
      */
     public function setNetMaskRequired($value)
     {
-        $this->internalNetMaskRequired = (trim(strtolower($value)) == 'y' || intval($value) == 1);
+        if (trim(strtoupper($value)) == "Y") {
+            $this->internalNetMaskRequired = true;
+        } else {
+            $this->internalNetMaskRequired = false;
+        }
     }
 
     /**

src/opnsense/mvc/app/models/OPNsense/Base/Validators/NetworkValidator.php

@@ -102,8 +102,7 @@ class NetworkValidator extends Validator implements ValidatorInterface
                     }
                 }
             }
-        }
-        else if($this->getOption('netMaskRequired') === true) {
+        } elseif ($this->getOption('netMaskRequired') === true) {
             $result = false;
         }