(legacy) use reverse mask instead of reverse address for ddns in dhcpd...

(legacy) use reverse mask instead of reverse address for ddns in dhcpd (https://github.com/opnsense/core/issues/352)

src/etc/inc/services.inc

@@ -600,13 +600,13 @@ EOPP;
 			} else {
 				$newzone['domain-name'] = $config['system']['domain'];
 			}
-			$revsubnet = explode(".", $subnet);
-			$revsubnet = array_reverse($revsubnet);
-			foreach ($revsubnet as $octet) {
-				if ($octet != "0")
-					break;
+			$revsubnet = array_reverse(explode(".", $subnet));
+			$subnetmask_rev = array_reverse(explode('.', $subnetmask));
+			foreach ($subnetmask_rev as $octet) {
+				if ($octet == "0") {
 					array_shift($revsubnet);
 				}
+			}
 			$newzone['ptr-domain'] = implode(".", $revsubnet) . ".in-addr.arpa";
 		}