Skip to content

O
OpnSense
Commit 674fa982 authored by Ad Schellevis's avatar Ad Schellevis
Browse files
Options

(legacy) refactor services_dnsmasq_edit.php

parent 9fe3e401
Hide whitespace changes
Inline Side-by-side
Showing with 272 additions and 281 deletions
src/www/services_dnsmasq_edit.php
View file @ 674fa982
<?php <?php
/* /*
Copyright (C) 2014-2015 Deciso B.V. Copyright (C) 2014-2016 Deciso B.V.
Copyright (C) 2003-2004 Bob Zoller <bob@kludgebox.com> and Manuel Kasper <mk@neon1.net>. Copyright (C) 2003-2004 Bob Zoller <bob@kludgebox.com> and Manuel Kasper <mk@neon1.net>.
All rights reserved. All rights reserved.
Redistribution and use in source and binary forms, with or without Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met: modification, are permitted provided that the following conditions are met:
1. Redistributions of source code must retain the above copyright notice, 1. Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer. this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright 2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution. documentation and/or other materials provided with the distribution.
THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE. POSSIBILITY OF SUCH DAMAGE.
*/ */
require_once("guiconfig.inc"); require_once("guiconfig.inc");
...@@ -33,281 +33,272 @@ require_once("interfaces.inc"); ...@@ -33,281 +33,272 @@ require_once("interfaces.inc");
function hostcmp($a, $b) function hostcmp($a, $b)
{ {
return strcasecmp($a['host'], $b['host']); return strcasecmp($a['host'], $b['host']);
} }
function hosts_sort() if (empty($config['dnsmasq']['hosts']) || !is_array($config['dnsmasq']['hosts'])) {
{ $config['dnsmasq']['hosts'] = array();
global $config;
if (!isset($config['dnsmasq']['hosts'])) {
return;
}
usort($config['dnsmasq']['hosts'], "hostcmp");
} }
$referer = (isset($_SERVER['HTTP_REFERER']) ? $_SERVER['HTTP_REFERER'] : '/services_dnsmasq.php');
if (!is_array($config['dnsmasq']['hosts']))
$config['dnsmasq']['hosts'] = array();
$a_hosts = &$config['dnsmasq']['hosts']; $a_hosts = &$config['dnsmasq']['hosts'];
if (is_numericint($_GET['id'])) if ($_SERVER['REQUEST_METHOD'] === 'GET') {
$id = $_GET['id']; if (isset($_GET['id']) && !empty($a_hosts[$_GET['id']])) {
if (isset($_POST['id']) && is_numericint($_POST['id'])) $id = $_GET['id'];
$id = $_POST['id']; }
$config_copy_fieldnames = array('host', 'domain', 'ip', 'descr', 'aliases');
if (isset($id) && $a_hosts[$id]) { foreach ($config_copy_fieldnames as $fieldname) {
$pconfig['host'] = $a_hosts[$id]['host']; if (isset($id) && isset($a_hosts[$id][$fieldname])) {
$pconfig['domain'] = $a_hosts[$id]['domain']; $pconfig[$fieldname] = $a_hosts[$id][$fieldname];
$pconfig['ip'] = $a_hosts[$id]['ip']; } else {
$pconfig['descr'] = $a_hosts[$id]['descr']; $pconfig[$fieldname] = null;
$pconfig['aliases'] = $a_hosts[$id]['aliases']; }
}
} elseif ($_SERVER['REQUEST_METHOD'] === 'POST') {
if (isset($_POST['id']) && !empty($a_hosts[$_POST['id']])) {
$id = $_POST['id'];
}
$input_errors = array();
$pconfig = $_POST;
$pconfig['aliases'] = array();
if (isset($pconfig['aliases_host'])) {
$pconfig['aliases']['item'] = array();
foreach ($pconfig['aliases_host'] as $opt_seq => $opt_host) {
if (!empty($opt_host)) {
$pconfig['aliases']['item'][] = array('host' => $opt_host,
'domain' => $pconfig['aliases_domain'][$opt_seq],
'description' => $pconfig['aliases_description'][$opt_seq]
);
}
}
}
/* input validation */
$reqdfields = explode(" ", "domain ip");
$reqdfieldsn = array(gettext("Domain"),gettext("IP address"));
do_input_validation($pconfig, $reqdfields, $reqdfieldsn, $input_errors);
if (!empty($pconfig['host']) && !is_hostname($pconfig['host'])) {
$input_errors[] = gettext("The hostname can only contain the characters A-Z, 0-9 and '-'.");
}
if (!empty($pconfig['domain']) && !is_domain($pconfig['domain'])) {
$input_errors[] = gettext("A valid domain must be specified.");
}
if (!empty($pconfig['ip']) && !is_ipaddr($pconfig['ip'])) {
$input_errors[] = gettext("A valid IP address must be specified.");
}
/* validate aliases */
foreach ($pconfig['aliases']['item'] as $idx => $alias) {
$aliasreqdfields = array('domain');
$aliasreqdfieldsn = array(gettext("Alias Domain"));
do_input_validation($alias, $aliasreqdfields, $aliasreqdfieldsn, $input_errors);
if (!empty($alias['host']) && !is_hostname($alias['host'])) {
$input_errors[] = gettext("Hostnames in alias list can only contain the characters A-Z, 0-9 and '-'.");
}
if (!empty($alias['domain']) && !is_domain($alias['domain'])) {
$input_errors[] = gettext("A valid domain must be specified in alias list.");
}
}
/* check for overlaps */
foreach ($a_hosts as $hostent) {
if (isset($id) && $a_hosts[$id] === $hostent) {
continue;
}
if (($hostent['host'] == $pconfig['host']) && ($hostent['domain'] == $pconfig['domain'])
&& ((is_ipaddrv4($hostent['ip']) && is_ipaddrv4($pconfig['ip'])) || (is_ipaddrv6($hostent['ip']) && is_ipaddrv6($pconfig['ip'])))) {
$input_errors[] = gettext("This host/domain already exists.");
break;
}
}
if (count($input_errors) == 0) {
$hostent = array();
$hostent['host'] = $pconfig['host'];
$hostent['domain'] = $pconfig['domain'];
$hostent['ip'] = $pconfig['ip'];
$hostent['descr'] = $pconfig['descr'];
$hostent['aliases'] = $pconfig['aliases'];
if (isset($id)) {
$a_hosts[$id] = $hostent;
} else {
$a_hosts[] = $hostent;
}
usort($config['dnsmasq']['hosts'], "hostcmp");
mark_subsystem_dirty('hosts');
write_config();
header("Location: services_dnsmasq.php");
exit;
}
} }
if ($_POST) {
unset($input_errors);
$pconfig = $_POST;
/* input validation */
$reqdfields = explode(" ", "domain ip");
$reqdfieldsn = array(gettext("Domain"),gettext("IP address"));
do_input_validation($_POST, $reqdfields, $reqdfieldsn, $input_errors);
if (($_POST['host'] && !is_hostname($_POST['host'])))
$input_errors[] = gettext("The hostname can only contain the characters A-Z, 0-9 and '-'.");
if (($_POST['domain'] && !is_domain($_POST['domain'])))
$input_errors[] = gettext("A valid domain must be specified.");
if (($_POST['ip'] && !is_ipaddr($_POST['ip'])))
$input_errors[] = gettext("A valid IP address must be specified.");
/* collect aliases */
$aliases = array();
foreach ($_POST as $key => $value) {
$entry = '';
if (!substr_compare('aliashost', $key, 0, 9)) {
$entry = substr($key, 9);
$field = 'host';
}
elseif (!substr_compare('aliasdomain', $key, 0, 11)) {
$entry = substr($key, 11);
$field = 'domain';
}
elseif (!substr_compare('aliasdescription', $key, 0, 16)) {
$entry = substr($key, 16);
$field = 'description';
}
if (ctype_digit($entry)) {
$aliases[$entry][$field] = $value;
}
}
$pconfig['aliases']['item'] = $aliases;
/* validate aliases */
foreach ($aliases as $idx => $alias) {
$aliasreqdfields = array('aliasdomain' . $idx);
$aliasreqdfieldsn = array(gettext("Alias Domain"));
//var_dump(array('fields' => $aliasreqdfields, 'names' => $aliasreqdfieldsn, 'alias' => $alias));
do_input_validation($_POST, $aliasreqdfields, $aliasreqdfieldsn, $input_errors);
if (($alias['host'] && !is_hostname($alias['host']))) {
$input_errors[] = gettext("Hostnames in alias list can only contain the characters A-Z, 0-9 and '-'.");
}
if (($alias['domain'] && !is_domain($alias['domain']))) {
$input_errors[] = gettext("A valid domain must be specified in alias list.");
}
}
/* check for overlaps */
foreach ($a_hosts as $hostent) {
if (isset($id) && ($a_hosts[$id]) && ($a_hosts[$id] === $hostent))
continue;
if (($hostent['host'] == $_POST['host']) && ($hostent['domain'] == $_POST['domain'])
&& ((is_ipaddrv4($hostent['ip']) && is_ipaddrv4($_POST['ip'])) || (is_ipaddrv6($hostent['ip']) && is_ipaddrv6($_POST['ip'])))) {
$input_errors[] = gettext("This host/domain already exists.");
break;
}
}
if (!$input_errors) {
$hostent = array();
$hostent['host'] = $_POST['host'];
$hostent['domain'] = $_POST['domain'];
$hostent['ip'] = $_POST['ip'];
$hostent['descr'] = $_POST['descr'];
$hostent['aliases']['item'] = $aliases;
if (isset($id) && $a_hosts[$id])
$a_hosts[$id] = $hostent;
else
$a_hosts[] = $hostent;
hosts_sort();
mark_subsystem_dirty('hosts');
write_config();
header("Location: services_dnsmasq.php");
exit;
}
}
$service_hook = 'dnsmasq'; $service_hook = 'dnsmasq';
legacy_html_escape_form_data($pconfig);
include("head.inc"); include("head.inc");
?> ?>
<body> <body>
<?php include("fbegin.inc"); ?> <?php include("fbegin.inc"); ?>
<script type="text/javascript" src="/javascript/row_helper.js"></script>
<script type="text/javascript"> <script type="text/javascript">
//<![CDATA[ $( document ).ready(function() {
rowname[0] = "aliashost"; /**
rowtype[0] = "textbox"; * Aliases
rowsize[0] = "20"; */
rowname[1] = "aliasdomain"; function removeRow() {
rowtype[1] = "textbox"; if ( $('#aliases_table > tbody > tr').length == 1 ) {
rowsize[1] = "20"; $('#aliases_table > tbody > tr:last > td > input').each(function(){
rowname[2] = "aliasdescription"; $(this).val("");
rowtype[2] = "textbox"; });
rowsize[2] = "20"; } else {
//]]> $(this).parent().parent().remove();
}
}
// add new detail record
$("#addNew").click(function(){
// copy last row and reset values
$('#aliases_table > tbody').append('<tr>'+$('#aliases_table > tbody > tr:last').html()+'</tr>');
$('#aliases_table > tbody > tr:last > td > input').each(function(){
$(this).val("");
});
$(".act-removerow").click(removeRow);
});
$(".act-removerow").click(removeRow);
});
</script> </script>
<section class="page-content-main">
<section class="page-content-main"> <div class="container-fluid">
<div class="row">
<div class="container-fluid"> <?php if (isset($input_errors) && count($input_errors) > 0) print_input_errors($input_errors); ?>
<section class="col-xs-12">
<div class="row"> <div class="content-box">
<?php if (isset($input_errors) && count($input_errors) > 0) print_input_errors($input_errors); ?> <form method="post" name="iform" id="iform">
<div class="table-responsive">
<section class="col-xs-12"> <table class="table table-striped">
<tr>
<div class="content-box"> <td width="22%"><strong><?=gettext("Edit DNS Forwarder entry");?></strong></td>
<td width="78%" align="right">
<form action="services_dnsmasq_edit.php" method="post" name="iform" id="iform"> <small><?=gettext("full help"); ?> </small>
<i class="fa fa-toggle-off text-danger" style="cursor: pointer;" id="show_all_help_page" type="button"></i></a>
<div class="table-responsive"> </td>
<table class="table table-striped table-sort"> </tr>
<tr> <tr>
<td colspan="2" valign="top" class="listtopic"><?=gettext("Edit DNS Forwarder entry");?></td> <td><a id="help_for_host" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("Host");?></td>
</tr> <td>
<tr> <input name="host" type="text" id="host" value="<?=$pconfig['host'];?>" />
<td width="22%" valign="top" class="vncell"><?=gettext("Host");?></td> <div class="hidden" for="help_for_host">
<td width="78%" class="vtable"> <?=gettext("Name of the host, without"." domain part"); ?><br />
<input name="host" type="text" class="formfld" id="host" size="40" value="<?=htmlspecialchars($pconfig['host']);?>" /> <?=gettext("e.g."); ?> <em><?=gettext("myhost"); ?></em>
<br /> <span class="vexpl"><?=gettext("Name of the host, without". </div>
" domain part"); ?><br /> </td>
<?=gettext("e.g."); ?> <em><?=gettext("myhost"); ?></em></span></td> </tr>
</tr> <tr>
<tr> <td><a id="help_for_domain" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("Domain");?></td>
<td width="22%" valign="top" class="vncellreq"><?=gettext("Domain");?></td> <td>
<td width="78%" class="vtable"> <input name="domain" type="text" id="domain" value="<?=$pconfig['domain'];?>" />
<input name="domain" type="text" class="formfld" id="domain" size="40" value="<?=htmlspecialchars($pconfig['domain']);?>" /> <div class="hidden" for="help_for_domain">
<br /> <span class="vexpl"><?=gettext("Domain of the host"); ?><br /> <?=gettext("Domain of the host"); ?><br />
<?=gettext("e.g."); ?> <em><?=gettext("example.com"); ?></em></span></td> <?=gettext("e.g."); ?> <em><?=gettext("example.com"); ?></em>
</tr> </div>
<tr> </td>
<td width="22%" valign="top" class="vncellreq"><?=gettext("IP address");?></td> </tr>
<td width="78%" class="vtable"> <tr>
<input name="ip" type="text" class="formfld" id="ip" size="40" value="<?=htmlspecialchars($pconfig['ip']);?>" /> <td><a id="help_for_ip" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("IP address");?></td>
<br /> <span class="vexpl"><?=gettext("IP address of the host"); ?><br /> <td>
<?=gettext("e.g."); ?> <em>192.168.100.100</em> <?=gettext("or"); ?> <em>fd00:abcd::1</em></span></td> <input name="ip" type="text" id="ip" value="<?=$pconfig['ip'];?>" />
</tr> <div class="hidden" for="help_for_ip">
<tr> <?=gettext("IP address of the host"); ?><br />
<td width="22%" valign="top" class="vncell"><?=gettext("Description");?></td> <?=gettext("e.g."); ?> <em>192.168.100.100</em> <?=gettext("or"); ?> <em>fd00:abcd::1</em><
<td width="78%" class="vtable"> </div>
<input name="descr" type="text" class="formfld" id="descr" size="40" value="<?=htmlspecialchars($pconfig['descr']);?>" /> </td>
<br /> <span class="vexpl"><?=gettext("You may enter a description here". </tr>
" for your reference (not parsed).");?></span></td> <tr>
</tr> <td><a id="help_for_descr" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("Description");?></td>
<tr> <td>
<td width="22%" valign="top" class="vncell"><div id="addressnetworkport"><?=gettext("Aliases"); ?></div></td> <input name="descr" type="text" id="descr" value="<?=$pconfig['descr'];?>" />
<td width="78%" class="vtable"> <div class="hidden" for="help_for_descr">
<table id="maintable" summary="aliases"> <?=gettext("You may enter a description here"." for your reference (not parsed).");?>
<tbody> </div>
<tr> </td>
<td colspan="4"> </tr>
<div style="padding:5px; margin-top: 16px; margin-bottom: 16px; border:1px dashed #000066; background-color: #ffffff; color: #000000; font-size: 8pt;" id="itemhelp"> <tr>
<?=gettext("Enter additional names for this host."); ?> <td><a id="help_for_alias" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("Aliases"); ?></td>
</div> <td>
</td> <table class="table table-striped table-condensed" id="aliases_table">
</tr> <thead>
<tr> <tr>
<td><div id="onecolumn"><?=gettext("Host");?></div></td> <th></th>
<td><div id="twocolumn"><?=gettext("Domain");?></div></td> <th id="detailsHeading1"><?=gettext("Host"); ?></th>
<td><div id="threecolumn"><?=gettext("Description");?></div></td> <th id="detailsHeading3"><?=gettext("Domain"); ?></th>
</tr> <th id="updatefreqHeader" ><?=gettext("Description");?></th>
<?php </tr>
$counter = 0; </thead>
if (isset($pconfig['aliases']['item'])): <tbody>
foreach($pconfig['aliases']['item'] as $item): <?php
$host = $item['host']; if (empty($pconfig['aliases']['item'])) {
$domain = $item['domain']; $aliases = array();
$description = $item['description']; $aliases[] = array('number' => null, 'value' => null, 'type' => null);
?> } else {
<tr> $aliases = $pconfig['aliases']['item'];
<td> }
<input autocomplete="off" name="aliashost<?php echo $counter; ?>" type="text" class="formfld unknown" id="aliashost<?php echo $counter; ?>" size="20" value="<?=htmlspecialchars($host);?>" /> foreach($aliases as $item):?>
</td> <tr>
<td> <td>
<input autocomplete="off" name="aliasdomain<?php echo $counter; ?>" type="text" class="formfld unknown" id="aliasdomain<?php echo $counter; ?>" size="20" value="<?=htmlspecialchars($domain);?>" /> <div style="cursor:pointer;" class="act-removerow btn btn-default btn-xs" alt="remove"><span class="glyphicon glyphicon-minus"></span></div>
</td> </td>
<td> <td>
<input name="aliasdescription<?php echo $counter; ?>" type="text" class="formfld unknown" id="aliasdescription<?php echo $counter; ?>" size="20" value="<?=htmlspecialchars($description);?>" /> <input name="aliases_host[]" type="text" value="<?=$item['host'];?>" />
</td> </td>
<td> <td>
<a onclick="removeRow(this); return false;" href="#" title="<?=gettext("remove this entry"); ?>"> <input name="aliases_domain[]" type="text" value="<?=$item['domain'];?>" />
<div style="cursor:pointer;" class="act-removerow btn btn-default btn-xs" alt="remove"><span class="glyphicon glyphicon-minus"></span></div> </td>
</a> <td>
</td> <input name="aliases_description[]" type="text" value="<?=$item['description'];?>" />
</tr> </td>
<?php </tr>
$counter++; <?php
endforeach; endforeach;?>
endif; </tbody>
?> <tfoot>
</tbody> <tr>
</table> <td colspan="4">
<a onclick="javascript:addRowTo('maintable', 'formfldalias'); return false;" href="#" class="btn btn-default btn-xs"><span class="glyphicon glyphicon-plus"></span></a> <div id="addNew" style="cursor:pointer;" class="btn btn-default btn-xs" alt="add"><span class="glyphicon glyphicon-plus"></span></div>
<script type="text/javascript"> </td>
//<![CDATA[ </tr>
field_counter_js = 3; </tfoot>
rows = 1; </table>
totalrows = <?php echo $counter; ?>; <div class="hidden" for="help_for_alias">
loaded = <?php echo $counter; ?>; <?=gettext("Enter additional names for this host."); ?>
//]]> </div>
</script> </td>
</td> </tr>
</tr> <tr>
<tr> <td>&nbsp;</td>
<td width="22%" valign="top">&nbsp;</td> <td>
<td width="78%"> <input name="Submit" type="submit" class="btn btn-primary" value="<?=gettext("Save");?>" />
<input name="Submit" type="submit" class="btn btn-primary" value="<?=gettext("Save");?>" /> <input type="button" class="btn btn-default" value="<?=gettext("Cancel");?>" onclick="window.location.href='<?=(isset($_SERVER['HTTP_REFERER']) ? $_SERVER['HTTP_REFERER'] : '/services_dnsmasq.php');?>'" />
<input type="button" class="btn btn-default" value="<?=gettext("Cancel");?>" onclick="window.location.href='<?=$referer;?>'" /> <?php if (isset($id)): ?>
<?php if (isset($id) && $a_hosts[$id]): ?> <input name="id" type="hidden" value="<?=htmlspecialchars($id);?>" />
<input name="id" type="hidden" value="<?=htmlspecialchars($id);?>" /> <?php endif; ?>
<?php endif; ?> </td>
</td> </tr>
</tr> </table>
</table> </div>
</div> </form>
</form> </div>
</div> </section>
</section> </div>
</div> </div>
</div> </section>
</section>
<?php include("foot.inc"); ?> <?php include("foot.inc"); ?>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

Technounit-GROUP 2023