Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
O
OpnSense
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Kulya
OpnSense
Commits
5069d99c
Commit
5069d99c
authored
Dec 03, 2016
by
Ad Schellevis
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
(config) performance, parse by reference to isArraySequential(), reduces object creation
parent
7d9ae367
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
3 deletions
+3
-3
Config.php
src/opnsense/mvc/app/library/OPNsense/Core/Config.php
+3
-3
No files found.
src/opnsense/mvc/app/library/OPNsense/Core/Config.php
View file @
5069d99c
...
@@ -70,12 +70,12 @@ class Config extends Singleton
...
@@ -70,12 +70,12 @@ class Config extends Singleton
/**
/**
* check if array is a sequential type.
* check if array is a sequential type.
* @param $arrayData array structure to check
* @param
&array
$arrayData array structure to check
* @return bool
* @return bool
*/
*/
private
function
isArraySequential
(
$arrayData
)
private
function
isArraySequential
(
&
$arrayData
)
{
{
foreach
(
$arrayData
as
$key
=>
$value
)
{
foreach
(
$arrayData
as
$key
=>
&
$value
)
{
if
(
!
ctype_digit
(
strval
(
$key
)))
{
if
(
!
ctype_digit
(
strval
(
$key
)))
{
return
false
;
return
false
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment