Skip to content

O
OpnSense
Commit 3e170015 authored by Ad Schellevis's avatar Ad Schellevis Committed by Franco Fichtner
Browse files
Options

(legacy) quick refactor vpn_pptp_users_edit.php 

(cherry picked from commit ada16808)
parent c99aeee1
Show whitespace changes
Inline Side-by-side
Showing with 109 additions and 100 deletions
src/www/vpn_pptp_users_edit.php
View file @ 3e170015
<?php <?php
/* /*
Copyright (C) 2014-2015 Deciso B.V. Copyright (C) 2014-2016 Deciso B.V.
Copyright (C) 2003-2005 Manuel Kasper <mk@neon1.net>. Copyright (C) 2003-2005 Manuel Kasper <mk@neon1.net>.
All rights reserved. All rights reserved.
...@@ -54,19 +54,21 @@ if (!is_array($config['pptpd']['user'])) { ...@@ -54,19 +54,21 @@ if (!is_array($config['pptpd']['user'])) {
} }
$a_secret = &$config['pptpd']['user']; $a_secret = &$config['pptpd']['user'];
if (is_numericint($_GET['id'])) { if ($_SERVER['REQUEST_METHOD'] === 'GET') {
if (isset($_GET['id']) && !empty($a_secret[$_GET['id']])) {
$id = $_GET['id']; $id = $_GET['id'];
} }
if (isset($_POST['id']) && is_numericint($_POST['id'])) { if (isset($id)) {
$id = $_POST['id'];
}
if (isset($id) && $a_secret[$id]) {
$pconfig['username'] = $a_secret[$id]['name']; $pconfig['username'] = $a_secret[$id]['name'];
$pconfig['ip'] = $a_secret[$id]['ip']; $pconfig['ip'] = $a_secret[$id]['ip'];
} } else {
$pconfig['username'] = null;
if ($_POST) { $pconfig['ip'] = null;
}
} elseif ($_SERVER['REQUEST_METHOD'] === 'POST') {
if (isset($_POST['id']) && !empty($a_secret[$_POST['id']])) {
$id = $_POST['id'];
}
unset($input_errors); unset($input_errors);
$pconfig = $_POST; $pconfig = $_POST;
...@@ -137,73 +139,80 @@ if ($_POST) { ...@@ -137,73 +139,80 @@ if ($_POST) {
} }
} }
$service_hook = 'pptpd';
$service_hook = 'pptpd';
legacy_html_escape_form_data($pconfig);
include("head.inc"); include("head.inc");
?> ?>
<body> <body>
<?php include("fbegin.inc"); ?> <?php include("fbegin.inc"); ?>
<section class="page-content-main"> <section class="page-content-main">
<div class="container-fluid"> <div class="container-fluid">
<div class="row"> <div class="row">
<?php if (isset($input_errors) && count($input_errors) > 0) { <?php if (isset($input_errors) && count($input_errors) > 0) {
print_input_errors($input_errors); print_input_errors($input_errors);
} ?> } ?>
<section class="col-xs-12"> <section class="col-xs-12">
<div class="tab-content content-box col-xs-12"> <div class="tab-content content-box col-xs-12">
<form method="post" name="iform" id="iform">
<form action="vpn_pptp_users_edit.php" method="post" name="iform" id="iform">
<div class="table-responsive"> <div class="table-responsive">
<table class="table table-striped table-sort"> <table class="table table-striped">
<tr> <tr>
<td width="22%" valign="top" class="vncellreq"><?=gettext("Username");?></td> <td width="22%">
<td width="78%" class="vtable"> <strong><?=gettext("Edit User");?></strong>
<input name="username" type="text" class="form-control user" id="username" size="20" value="<?=htmlspecialchars($pconfig['username']);?>" /> </td>
<td width="78%" align="right">
<small><?=gettext("full help"); ?> </small>
<i class="fa fa-toggle-off text-danger" style="cursor: pointer;" id="show_all_help_page"></i>
</td> </td>
</tr> </tr>
<tr> <tr>
<td width="22%" valign="top" class="vncellreq"><?=gettext("Password");?></td> <td><i class="fa fa-info-circle text-muted"></i> <?=gettext("Username");?></td>
<td width="78%" class="vtable"> <td>
<input name="password" type="password" class="form-control pwd" id="password" size="20" /> <input name="username" type="text" id="username" value="<?=$pconfig['username'];?>" />
<br /><input name="password2" type="password" class="form-control pwd" id="password2" size="20" /> </td>
&nbsp;(<?=gettext("confirmation");?>)<?php if (isset($id) && $a_secret[$id]) :
?><br />
<span class="vexpl"><?=gettext("If you want to change the users' password, ".
"enter it here twice.");?></span><?php
endif; ?></td>
</tr> </tr>
<tr> <tr>
<td width="22%" valign="top" class="vncell"><?=gettext("IP address");?></td> <td><i class="fa fa-info-circle text-muted"></i> <?=gettext("Password");?></td>
<td width="78%" class="vtable"> <td>
<input name="ip" type="text" class="form-control unknown" id="ip" size="20" value="<?=htmlspecialchars($pconfig['ip']);?>" /> <input name="password" type="password" class="form-control pwd" id="password" />
<br /><span class="vexpl"><?=gettext("If you want the user to be assigned a specific IP address, enter it here.");?></span></td> <br /><input name="password2" type="password" class="form-control pwd" id="password2" />
&nbsp;(<?=gettext("confirmation");?>)
<?php
if (isset($id)) :?><br />
<?=gettext("If you want to change the users' password, ".
"enter it here twice.");?>
<?php
endif; ?>
</td>
</tr> </tr>
<tr> <tr>
<td class="vncell" width="22%" valign="top">&nbsp;</td> <td><a id="help_for_ip" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("IP address");?></td>
<td class="vncell" width="78%"> <td>
<input name="ip" type="text" class="form-control unknown" id="ip" value="<?=htmlspecialchars($pconfig['ip']);?>" />
<div class="hidden" for="help_for_ip">
<?=gettext("If you want the user to be assigned a specific IP address, enter it here.");?>
</div>
</td>
</tr>
<tr>
<td>&nbsp;</td>
<td>
<input name="Submit" type="submit" class="btn btn-primary" value="<?=gettext("Save");?>" /> <input name="Submit" type="submit" class="btn btn-primary" value="<?=gettext("Save");?>" />
<?php if (isset($id) && $a_secret[$id]) : <?php
?> if (isset($id)) :?>
<input name="id" type="hidden" value="<?=htmlspecialchars($id);?>" /> <input name="id" type="hidden" value="<?=$id;?>" />
<?php <?php
endif; ?> endif; ?>
</td> </td>
</tr> </tr>
</table> </table>
</div> </div>
</form> </form>
</div> </div>
</section> </section>
</div> </div>
</div> </div>
</section> </section>
<?php include("foot.inc"); <?php include("foot.inc");
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

Technounit-GROUP 2023