Commit 193351cf authored by Ad Schellevis's avatar Ad Schellevis Committed by Franco Fichtner

(legacy) interfaces.inc isset vs !empty

parent 3ccd2632
...@@ -2941,7 +2941,7 @@ function interface_configure($interface = 'wan', $reloadall = false, $linkupeven ...@@ -2941,7 +2941,7 @@ function interface_configure($interface = 'wan', $reloadall = false, $linkupeven
* the interface config again, which attempts to spoof the MAC again, * the interface config again, which attempts to spoof the MAC again,
* which cycles the link again... * which cycles the link again...
*/ */
if (isset($wancfg['spoofmac']) && ($wancfg['spoofmac'] != $mac)) { if (!empty($wancfg['spoofmac']) && ($wancfg['spoofmac'] != $mac)) {
mwexec("/sbin/ifconfig " . escapeshellarg($realhwif) . mwexec("/sbin/ifconfig " . escapeshellarg($realhwif) .
" link " . escapeshellarg($wancfg['spoofmac'])); " link " . escapeshellarg($wancfg['spoofmac']));
...@@ -2973,12 +2973,12 @@ function interface_configure($interface = 'wan', $reloadall = false, $linkupeven ...@@ -2973,12 +2973,12 @@ function interface_configure($interface = 'wan', $reloadall = false, $linkupeven
} }
/* media */ /* media */
if (isset($wancfg['media']) || isset($wancfg['mediaopt'])) { if (!empty($wancfg['media']) || !empty($wancfg['mediaopt'])) {
$cmd = "/sbin/ifconfig " . escapeshellarg($realhwif); $cmd = "/sbin/ifconfig " . escapeshellarg($realhwif);
if (isset($wancfg['media'])) { if (!empty($wancfg['media'])) {
$cmd .= " media " . escapeshellarg($wancfg['media']); $cmd .= " media " . escapeshellarg($wancfg['media']);
} }
if (isset($wancfg['mediaopt'])) { if (!empty($wancfg['mediaopt'])) {
$cmd .= " mediaopt " . escapeshellarg($wancfg['mediaopt']); $cmd .= " mediaopt " . escapeshellarg($wancfg['mediaopt']);
} }
mwexec($cmd); mwexec($cmd);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment